Set up the Advantage page to mount a React app #10089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huwshimi
commented
Jul 28, 2021
| @@ -7,7 +7,7 @@ | |||
| "esModuleInterop": true, | |||
| "forceConsistentCasingInFileNames": true, | |||
| "isolatedModules": true, | |||
| "jsx": "react-jsx", | |||
| "jsx": "react", | |||
There was a problem hiding this comment.
It seems esbuild does not support the new JSX transform yet so I've reverted this.
There was a problem hiding this comment.
What was the issue?
There was a problem hiding this comment.
It seems that esbuild has to add support for the React 17 JSX transform so I guess it just wasn't going to build with "react-jsx" (there were conflicting errors about needing React to be imported/not imported).
More details in the issue: evanw/esbuild#334.
ClementChaumel
approved these changes
Jul 28, 2021
| @@ -7,7 +7,7 @@ | |||
| "esModuleInterop": true, | |||
| "forceConsistentCasingInFileNames": true, | |||
| "isolatedModules": true, | |||
| "jsx": "react-jsx", | |||
| "jsx": "react", | |||
There was a problem hiding this comment.
What was the issue?
ClementChaumel
added
Review: Code +1
Review: QA +1
and removed
Review: Code needed
Review: QA needed
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
QA
Issue / Card
Fixes canonical-web-and-design/commercial-squad#85.