Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update u-off-screen utility #4639

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Conversation

steverydz
Copy link
Contributor

@steverydz steverydz commented Feb 1, 2023

Done

Updated the u-off-screen utility to reflect the recommend standard as recommended here: https://www.tpgi.com/the-anatomy-of-visually-hidden/

QA

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.
  • Documentation side navigation should be updated with the relevant labels.

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4639.demos.haus

@steverydz steverydz changed the title Update u-off-screen class to be more robust Update u-off-screen utility Feb 1, 2023
@steverydz steverydz marked this pull request as ready for review February 1, 2023 09:46
Copy link
Contributor

@ClementChaumel ClementChaumel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb 👍️

@steverydz
Copy link
Contributor Author

Can this be merged or are you waiting on a release?

@bartaz bartaz merged commit f984d48 into canonical:main Feb 10, 2023
@bartaz
Copy link
Member

bartaz commented Feb 10, 2023

@steverydz Once approved, if it has the version bump, and whatever else needed it can be merged.

Thanks for that!

@bartaz
Copy link
Member

bartaz commented Feb 21, 2023

For the record, this change seems to mess up a bit with how cypress detects if elements are visible or not visible. We found a workaround for that in React component for tooltip, but if this comes up later we may need to find a better solution.

Related fix in react components: canonical/react-components#888

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants