-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Typography changes #4734
Typography changes #4734
Conversation
Demo starting at https://vanilla-framework-4734.demos.haus |
@ClementChaumel @lyubomir-popov Percy results for review and reference: https://percy.io/bb49709b/vanilla-framework/builds/26624752/changed/1482189495 |
h3: 0.45rem, | ||
h3-mobile: 0.45rem, | ||
h4-large: 0.45rem, | ||
h4: 0.45rem, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lyubomir-popov This change is causing a huge shift. From almost nothing, to 0.45rem it's pushing all h4s (and related headings in components) almost whole spacing unit lower.
How should we compensate for that? Move everything else lower as well (icons that should align with that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the good thing is that all nudges are roughly the same value - so padding on top of text becomes more consistent.
* update small screen font-sizes, remove some unnecessary stuf * Clean up browser rounding compensations * Remove unnecessary font weights map --------- Co-authored-by: Bartek Szopka <bartek.szopka@canonical.com>
Co-authored-by: ClementChaumel <clement.chaumel@gmail.com>
Should this be closed in favour of the 4.0 branch? |
This can be closed as we have an official |
Done
[List of work items including drive-bys]
Fixes [list issues/bugs if needed]
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁
,Breaking Change 💣
,Bug 🐛
,Documentation 📝
,Maintenance 🔨
.package.json
should be updated relative to the most recent release, following semver convention:Screenshots
[if relevant, include a screenshot or screen capture]