Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typography changes #4734

Closed
wants to merge 17 commits into from
Closed

Typography changes #4734

wants to merge 17 commits into from

Conversation

ClementChaumel
Copy link
Contributor

Done

[List of work items including drive-bys]

Fixes [list issues/bugs if needed]

QA

  • Open demo
  • [Add QA steps]
  • Review updated documentation:
    • [List any updated documentation for review]

Check if PR is ready for release

If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:

  • PR should have one of the following labels to automatically categorise it in release notes:
    • Feature 🎁, Breaking Change 💣, Bug 🐛, Documentation 📝, Maintenance 🔨.
  • Vanilla version in package.json should be updated relative to the most recent release, following semver convention:
    • if CSS class names are not changed it can be bugfix relesase (x.x.X)
    • if CSS class names are changed/added/removed it should be minor version (x.X.0)
    • see the wiki for more details
  • Any changes to component class names (new patterns, variants, removed or added features) should be listed on the what's new page.

Screenshots

[if relevant, include a screenshot or screen capture]

@webteam-app
Copy link

Demo starting at https://vanilla-framework-4734.demos.haus

@bartaz
Copy link
Member

bartaz commented Apr 13, 2023

h3: 0.45rem,
h3-mobile: 0.45rem,
h4-large: 0.45rem,
h4: 0.45rem,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lyubomir-popov This change is causing a huge shift. From almost nothing, to 0.45rem it's pushing all h4s (and related headings in components) almost whole spacing unit lower.

How should we compensate for that? Move everything else lower as well (icons that should align with that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the good thing is that all nudges are roughly the same value - so padding on top of text becomes more consistent.

@ClementChaumel
Copy link
Contributor Author

Should this be closed in favour of the 4.0 branch?

@bartaz
Copy link
Member

bartaz commented Apr 28, 2023

This can be closed as we have an official vanilla-4.0 branch, demo available in #4751

@bartaz bartaz closed this Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants