Correct calculation of input padding to take real border width in con… #4954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Demo starting at https://vanilla-framework-4954.demos.haus |
|
The build fails due to undefined variable. Seems that the It would have to be moved up. I guess it would make sense to move it to spacing file. Right now it's defined in |
bartaz
reviewed
Mar 6, 2024
| @@ -117,7 +117,7 @@ $sp-after: ( | |||
| $spv-nudge: map-get($nudges, p) !default; // top: nudge; bottom: unit - nudge; result: height = exact multiple of base unit | |||
| $spv-nudge-compensation: $sp-unit - $spv-nudge !default; | |||
| $input-margin-bottom: $sp-unit * 4 - $spv-nudge * 2; | |||
| $input-vertical-padding: calc($spv-nudge - 1px); | |||
| $input-vertical-padding: calc($spv-nudge - $input-border-thickness); | |||
There was a problem hiding this comment.
Even with this adjustment I'm not sure if the padding is correct. We have border only on the bottom, so it seems we should have calculated it separately for top and bottom padding?
|
Reimplemented in #5389 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sideration
Done
Inpuit padding has a correctionm for border, but it uses a hard-coded 1px value. We set borders using a variable, which happens to be 1.5px. This PR corrects that error by referencing the variable instead of the hard-coded 1px value.
QA
Check if PR is ready for release
If this PR contains Vanilla SCSS code changes, it should contain the following changes to make sure it's ready for the release:
Feature 🎁,Breaking Change 💣,Bug 🐛,Documentation 📝,Maintenance 🔨.package.jsonshould be updated relative to the most recent release, following semver convention:Screenshots
[if relevant, include a screenshot or screen capture]