-
Notifications
You must be signed in to change notification settings - Fork 167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Percy examples combination - base/code
#5143
Merged
bartaz
merged 9 commits into
canonical:percy-examples-combination
from
jmuzina:examples-combination-base-code
Jun 21, 2024
Merged
Percy examples combination - base/code
#5143
bartaz
merged 9 commits into
canonical:percy-examples-combination
from
jmuzina:examples-combination-base-code
Jun 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmuzina
changed the title
Examples combination base code
Percy examples combination - Jun 17, 2024
base/code
jmuzina
force-pushed
the
percy-examples-combination
branch
from
June 18, 2024 15:24
f14436c
to
d1a0dbc
Compare
pastelcyborg
approved these changes
Jun 19, 2024
bartaz
reviewed
Jun 20, 2024
bartaz
added
Review: QA +1
Review: Code +1 (with changes)
and removed
Review: QA needed
Review: Code +1
labels
Jun 20, 2024
bartaz
approved these changes
Jun 20, 2024
jmuzina
changed the title
Percy examples combination -
Percy examples combination - Jun 20, 2024
base/code
base/code
jmuzina
force-pushed
the
examples-combination-base-code
branch
from
June 20, 2024 20:36
0abb21b
to
e5ad4dd
Compare
bartaz
reviewed
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combines
base/code
examples.Inline & block were moved into a new
base/code
directory so that they could be combined inbase/code/combined
. So I also added redirects to keep their old links supported.Depends on #5142 (includes its code)
QA