Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add database reference to integrations doc #93

Merged
merged 3 commits into from
Jun 30, 2023
Merged

Add database reference to integrations doc #93

merged 3 commits into from
Jun 30, 2023

Conversation

gtrkiller
Copy link
Contributor

After removing the old db relation, the integration doc needs a reference to the new database relation.

yanksyoon
yanksyoon previously approved these changes Jun 28, 2023
Copy link
Collaborator

@yanksyoon yanksyoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docs!

yhaliaw
yhaliaw previously approved these changes Jun 29, 2023
docs/reference/integrations.md Outdated Show resolved Hide resolved
docs/reference/integrations.md Outdated Show resolved Hide resolved
docs/reference/integrations.md Outdated Show resolved Hide resolved
docs/reference/integrations.md Outdated Show resolved Hide resolved
docs/reference/integrations.md Outdated Show resolved Hide resolved
@gtrkiller gtrkiller dismissed stale reviews from yhaliaw and yanksyoon via a7a8e1e June 29, 2023 18:06
Copy link
Contributor

@gregory-schiano gregory-schiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

Test coverage for a7a8e1e

Name                Stmts   Miss Branch BrPart  Cover   Missing
---------------------------------------------------------------
src/charm.py          520     39    163     27    90%   203-206, 344-345, 557, 607, 667, 702-703, 753-759, 764, 866, 871-872, 944, 951, 1043, 1052, 1064, 1085, 1094, 1113, 1117, 1146, 1199, 1331, 1353, 1360->1362, 1401->exit, 1413, 1430-1432, 1450, 1459-1460
src/cos.py             15      0      0      0   100%
src/exceptions.py      17      1      2      1    89%   41
src/types_.py          15      0      0      0   100%
---------------------------------------------------------------
TOTAL                 567     40    165     28    90%

Static code analysis report

Run started:2023-06-29 18:13:05.609830

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 4914
  Total lines skipped (#nosec): 4
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@gtrkiller gtrkiller merged commit 09fc81a into main Jun 30, 2023
@gtrkiller gtrkiller deleted the add_docs branch June 30, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants