Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reckon extracts a list of tokens not from a CSV row itself, but from a generated ledger description line using
tr.downcase.split(/[\s\-]/)
which also includes;
in the list of the tokens.If reckon detects two description columns and one of them is empty it generates unnecessary
;
in the ledger row and it breaks tokenization.This PR does not fix the root cause of the problem but it fixes the immediate issue in #51 and adds some cosmetic benefits.
To fix the root cause probably need to improve token extraction and extend token list by splitting the description by non-word symbols...