error on a regex

[rezayi]

I have a regular expression as bellow:
var t = /[\p{Lu}]/u;
Both of google-chrome browser and nodejs can run this code.
but Javet cannot run this and throws bellow Exception:

com.caoccao.javet.exceptions.JavetCompilationException: SyntaxError: Invalid regular expression: /[\p{Lu}]/: Invalid property name in character class
	at com.caoccao.javet.interop.V8Native.execute(Native Method)
	at com.caoccao.javet.interop.V8Runtime.execute(V8Runtime.java:802)
	at com.caoccao.javet.interop.executors.V8StringExecutor.execute(V8StringExecutor.java:76)
	at com.caoccao.javet.interop.IV8Executable.executeVoid(IV8Executable.java:170)

Note that this regex included in remote javascript file and i cannot change it!
Can anyone help me?

[caoccao]

I believe this feature is part of the V8 i18n which is not supported by Javet. So, why doesn't Javet support i18n?

• To reduce the library size.
• To avoid embedding huge amount of i18n related files.
• To be able to host multiple Node.js runtimes. (Node.js with i18n only allows one runtime and the attempt on creating the second runtime causes the JVM to crash immediately.)

May I know which mode you are using? If it's V8 mode, I think there's a chance to enable the i18n. But that would be a private build, case by case. Please let me if you have any questions.

[caoccao]

I have tried the i18n enabled build and it works well. Please refer to this commit for detail.

try (V8Runtime v8Runtime = V8Host.getV8Instance().createV8Runtime()) {
    try (V8ValueRegExp v8ValueRegExp = v8Runtime.getExecutor("/[\\p{Lu}]/u").execute()) {
        System.out.println(v8ValueRegExp.toString()); // Output: /[\p{Lu}]/u
    }
}

[rezayi]

Thanks a lot.
I'm checking it.
I will report the result

[rezayi]

Hi.
I checked it and have problems yes. I'm using docker for my change.
I referred to the commit that you said and I checked out that.
then I changed v8_enable_i18n_support to true in base.Dockerfile and built it.
after that i used that inside build.Dockerfile.
In this step I saw this errors and It could not build libjavet-v8 library.

Step 7/15 : RUN  sh ./build-linux.sh -DV8_DIR=/google/v8
 ---> Running in 71ef21bffe03
-- The C compiler identification is GNU 9.4.0
-- The CXX compiler identification is GNU 9.4.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /usr/bin/cc - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Check for working CXX compiler: /usr/bin/c++ - skipped
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Configuring done
-- Generating done
-- Build files have been written to: /Javet/cpp/build
[  4%] Building CXX object CMakeFiles/JavetStatic.dir/jni/com_caoccao_javet_interop_NodeNative.cpp.o
[  9%] Building CXX object CMakeFiles/JavetStatic.dir/jni/com_caoccao_javet_interop_V8Native.cpp.o
[ 13%] Building CXX object CMakeFiles/Javet.dir/jni/com_caoccao_javet_interop_NodeNative.cpp.o
[ 18%] Building CXX object CMakeFiles/JavetStatic.dir/jni/javet_callbacks.cpp.o
�[91mIn file included from /google/v8/src/objects/js-proxy-inl.h:8,
                 from /google/v8/src/objects/objects-inl.h:29,
                 from /Javet/cpp/jni/javet_v8_internal.h:35,
                 from /Javet/cpp/jni/javet_exceptions.h:23,
                 from /Javet/cpp/jni/com_caoccao_javet_interop_V8Native.cpp:22:
/google/v8/src/objects/instance-type-inl.h:106:8: error: no declaration matches 'bool v8::internal::HeapObject::IsJSCollator() const'
  106 |   bool HeapObject::Is##type() const {                                          \
      |        ^~~~~~~~~~
/google/v8/src/objects/instance-type-inl.h:106:8: note: in definition of macro 'TYPE_CHECKER'
  106 |   bool HeapObject::Is##type() const {                                          \
      |        ^~~~~~~~~~
/google/v8/src/objects/instance-type.h:259:3: note: in expansion of macro 'TORQUE_INSTANCE_CHECKERS_SINGLE_FULLY_DEFINED'
  259 |   TORQUE_INSTANCE_CHECKERS_SINGLE_FULLY_DEFINED(V) \
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/google/v8/src/objects/instance-type.h:274:3: note: in expansion of macro 'INSTANCE_TYPE_CHECKERS_SINGLE'
  274 |   INSTANCE_TYPE_CHECKERS_SINGLE(V) \
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/google/v8/src/objects/instance-type-inl.h:125:1: note: in expansion of macro 'INSTANCE_TYPE_CHECKERS'
  125 | INSTANCE_TYPE_CHECKERS(TYPE_CHECKER)
      | ^~~~~~~~~~~~~~~~~~~~~~
/google/v8/src/objects/instance-type-inl.h:106:8: note: no functions named 'bool v8::internal::HeapObject::IsJSCollator() const'
  106 |   bool HeapObject::Is##type() const {                                          \
      |        ^~~~~~~~~~
/google/v8/src/objects/instance-type-inl.h:106:8: note: in definition of macro 'TYPE_CHECKER'
  106 |   bool HeapObject::Is##type() const {                                          \
      |        ^~~~~~~~~~
/google/v8/src/objects/instance-type.h:259:3: note: in expansion of macro 'TORQUE_INSTANCE_CHECKERS_SINGLE_FULLY_DEFINED'
  259 |   TORQUE_INSTANCE_CHECKERS_SINGLE_FULLY_DEFINED(V) \
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/google/v8/src/objects/instance-type.h:274:3: note: in expansion of macro 'INSTANCE_TYPE_CHECKERS_SINGLE'
  274 |   INSTANCE_TYPE_CHECKERS_SINGLE(V) \
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/google/v8/src/objects/instance-type-inl.h:125:1: note: in expansion of macro 'INSTANCE_TYPE_CHECKERS'
  125 | INSTANCE_TYPE_CHECKERS(TYPE_CHECKER)
      | ^~~~~~~~~~~~~~~~~~~~~~
�[0m�[91mIn file included from /google/v8/src/objects/smi.h:9,
                 from /google/v8/src/objects/fixed-array.h:11,
                 from /google/v8/src/objects/contexts.h:9,
                 from /google/v8/src/execution/thread-local-top.h:13,
                 from /google/v8/src/execution/isolate-data.h:12,
                 from /google/v8/src/execution/isolate.h:28,
                 from /google/v8/src/common/ptr-compr-inl.h:9,
                 from /google/v8/src/objects/objects-inl.h:20,
                 from /Javet/cpp/jni/javet_v8_internal.h:35,
                 from /Javet/cpp/jni/javet_exceptions.h:23,
                 from /Javet/cpp/jni/com_caoccao_javet_interop_V8Native.cpp:22:
/google/v8/src/objects/heap-object.h:27:7: note: 'class v8::internal::HeapObject' defined here
   27 | class HeapObject : public Object {
      |       ^~~~~~~~~~
�[0m�[91mIn file included from /google/v8/src/objects/js-proxy-inl.h:8,
                 from /google/v8/src/objects/objects-inl.h:29,
                 from /Javet/cpp/jni/javet_v8_internal.h:35,
                 from /Javet/cpp/jni/javet_exceptions.h:23,
                 from /Javet/cpp/jni/com_caoccao_javet_interop_V8Native.cpp:22:
/google/v8/src/objects/instance-type-inl.h:117:8: error: no declaration matches 'bool v8::internal::HeapObject::IsJSCollator(v8::internal::PtrComprCageBase) const'
  117 |   bool HeapObject::Is##type(PtrComprCageBase cage_base) const {                \
      |        ^~~~~~~~~~
/google/v8/src/objects/instance-type-inl.h:117:8: note: in definition of macro 'TYPE_CHECKER'
  117 |   bool HeapObject::Is##type(PtrComprCageBase cage_base) const {                \
      |        ^~~~~~~~~~
/google/v8/src/objects/instance-type.h:259:3: note: in expansion of macro 'TORQUE_INSTANCE_CHECKERS_SINGLE_FULLY_DEFINED'
  259 |   TORQUE_INSTANCE_CHECKERS_SINGLE_FULLY_DEFINED(V) \
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/google/v8/src/objects/instance-type.h:274:3: note: in expansion of macro 'INSTANCE_TYPE_CHECKERS_SINGLE'
  274 |   INSTANCE_TYPE_CHECKERS_SINGLE(V) \
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/google/v8/src/objects/instance-type-inl.h:125:1: note: in expansion of macro 'INSTANCE_TYPE_CHECKERS'
  125 | INSTANCE_TYPE_CHECKERS(TYPE_CHECKER)
      | ^~~~~~~~~~~~~~~~~~~~~~
�[0m�[91m/google/v8/src/objects/instance-type-inl.h:117:8: note: no functions named 'bool v8::internal::HeapObject::IsJSCollator(v8::internal::PtrComprCageBase) const'
  117 |   bool HeapObject::Is##type(PtrComprCageBase cage_base) const {                \
      |        ^~~~~~~~~~
/google/v8/src/objects/instance-type-inl.h:117:8: note: in definition of macro 'TYPE_CHECKER'
  117 |   bool HeapObject::Is##type(PtrComprCageBase cage_base) const {                \
      |        ^~~~~~~~~~
/google/v8/src/objects/instance-type.h:259:3: note: in expansion of macro 'TORQUE_INSTANCE_CHECKERS_SINGLE_FULLY_DEFINED'
  259 |   TORQUE_INSTANCE_CHECKERS_SINGLE_FULLY_DEFINED(V) \
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/google/v8/src/objects/instance-type.h:274:3: note: in expansion of macro 'INSTANCE_TYPE_CHECKERS_SINGLE'
  274 |   INSTANCE_TYPE_CHECKERS_SINGLE(V) \
      |   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/google/v8/src/objects/instance-type-inl.h:125:1: note: in expansion of macro 'INSTANCE_TYPE_CHECKERS'
  125 | INSTANCE_TYPE_CHECKERS(TYPE_CHECKER)
      | ^~~~~~~~~~~~~~~~~~~~~~
�[0m�[91mIn file included from /google/v8/src/objects/smi.h:9,
                 from /google/v8/src/objects/fixed-array.h:11,
                 from /google/v8/src/objects/contexts.h:9,
                 from /google/v8/src/execution/thread-local-top.h:13,
                 from /google/v8/src/execution/isolate-data.h:12,
                 from /google/v8/src/execution/isolate.h:28,
                 from /google/v8/src/common/ptr-compr-inl.h:9,
                 from /google/v8/src/objects/objects-inl.h:20,
                 from /Javet/cpp/jni/javet_v8_internal.h:35,
                 from /Javet/cpp/jni/javet_exceptions.h:23,
                 from /Javet/cpp/jni/com_caoccao_javet_interop_V8Native.cpp:22:
/google/v8/src/objects/heap-object.h:27:7: note: 'class v8::internal::HeapObject' defined here
   27 | class HeapObject : public Object {
      |       ^~~~~~~~~~
�[0m�[91mIn file included from /google/v8/src/objects/js-proxy-inl.h:8,
                 from /google/v8/src/objects/objects-inl.h:29,
                 from /Javet/cpp/jni/javet_v8_internal.h:35,
                 from /Javet/cpp/jni/javet_exceptions.h:23,
                 from /Javet/cpp/jni/com_caoccao_javet_interop_V8Native.cpp:22:
/google/v8/src/objects/instance-type-inl.h:106:8: error: no declaration matches 'bool v8::internal::HeapObject::IsJSDateTimeFormat() const'
  106 |   bool HeapObject::Is##type() const {                                          \
      |        ^~~~~~~~~~
...

can you please help me build this or send me final generated javet jar file that you created and test it?

[caoccao]

The .so build command needs to be changed as well. Please review my commit carefully and you will get it.

[rezayi]

Thanks a lot.
the problem resolved. you helped me a lot.