Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement _detect via tester #829

Merged
merged 1 commit into from
Jul 2, 2015
Merged

Implement _detect via tester #829

merged 1 commit into from
Jul 2, 2015

Conversation

megawac
Copy link
Collaborator

@megawac megawac commented Jul 2, 2015

As I mentioned in the #828 pull request, this is easy to extend to _detect. Also should detectLimit be added?

@aearly
Copy link
Collaborator

aearly commented Jul 2, 2015

detectLimit seems trivial to add -- most of the work would be covering it with tests.

aearly added a commit that referenced this pull request Jul 2, 2015
@aearly
Merge pull request #829 from megawac/find-tester
6364921 
Implement _detect via tester
@aearly aearly merged commit 6364921 into caolan:master Jul 2, 2015
@megawac megawac mentioned this pull request Jul 10, 2015
Closed
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@megawac @aearly