Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't type cast non-sensible values #219

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

voxpelli
Copy link
Contributor

Fixes #186 by checking if it's a sensible value before it casts it, so that non-sensible values won't be casted to eg. a string

@voxpelli

This comment has been minimized.

@ljharb

This comment has been minimized.

@ljharb
Copy link
Collaborator

ljharb commented Jan 20, 2021

I'd need to see some test cases that cover this new behavior.

What is a "non-sensible" value? As I mentioned in #186, values sent over the wire are only ever strings, so it's a bit strange to allow a non-serializable value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pre parsing validation
2 participants