You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently all of the code is in one very big package that is designed to work with capacitor + ios/android. This makes adding react native support, tests really difficult.
This would allow for very precise testing as well as relatively easy implementation of the react native platform.
It is a good step forward both in terms of code stability and adding new platforms
Platform(s)
Android, Ios
Preferred Solution
I propose that we abstract away the core logic (downloading, unzipping, etc) into a separate library that will not depend on capacitor nor on any ios/android specific feature and a package implementing this new library for the capacitor platform. The structure would be like so:
I think this is a good idea if we manage to make the capacitor the more dumb possible.
Just call the right function in the lib and set the settings, including giving the right folder to save and the right method to change path.
The rest should be done in the lib.
The lib should be in the plugin, not published anywhere for now
Feature Request
Description
Currently all of the code is in one very big package that is designed to work with capacitor + ios/android. This makes adding react native support, tests really difficult.
This would allow for very precise testing as well as relatively easy implementation of the
react native
platform.It is a good step forward both in terms of code stability and adding new platforms
Platform(s)
Android, Ios
Preferred Solution
I propose that we abstract away the core logic (downloading, unzipping, etc) into a separate library that will not depend on capacitor nor on any ios/android specific feature and a package implementing this new library for the capacitor platform. The structure would be like so:
Alternatives
None
Additional Context
This is related to #266 as well as #361
Partial update would be heavily impacted by this change so perhaps we should conciser doing partial first
The text was updated successfully, but these errors were encountered: