Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: abstract the updater into a standalone lib #392

Open
WcaleNieWolny opened this issue Jun 22, 2024 · 1 comment
Open

feat: abstract the updater into a standalone lib #392

WcaleNieWolny opened this issue Jun 22, 2024 · 1 comment

Comments

@WcaleNieWolny
Copy link
Contributor

Feature Request

Description

Currently all of the code is in one very big package that is designed to work with capacitor + ios/android. This makes adding react native support, tests really difficult.

This would allow for very precise testing as well as relatively easy implementation of the react native platform.

It is a good step forward both in terms of code stability and adding new platforms

Platform(s)

Android, Ios

Preferred Solution

I propose that we abstract away the core logic (downloading, unzipping, etc) into a separate library that will not depend on capacitor nor on any ios/android specific feature and a package implementing this new library for the capacitor platform. The structure would be like so:

ios:
 - core
 - capacitor
 android:
  - core
  - capacitor

Alternatives

None

Additional Context

This is related to #266 as well as #361

Partial update would be heavily impacted by this change so perhaps we should conciser doing partial first

@riderx
Copy link
Collaborator

riderx commented Aug 27, 2024

I think this is a good idea if we manage to make the capacitor the more dumb possible.
Just call the right function in the lib and set the settings, including giving the right folder to save and the right method to change path.
The rest should be done in the lib.
The lib should be in the plugin, not published anywhere for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants