generated from SAP/repository-template
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor QL #201
Merged
Merged
Refactor QL #201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mariayord this PR is quite excessive as it is a fundamental rewrite. I guess it needs a lot of testing to make sure no overload that was allowed before got lost... we can surely have a look together if you'd like. |
This was referenced Sep 25, 2024
Closed
vkozyura
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #227
Fixes #146
Rework QL to streamline many signatures and reuse recurring parts.
Grouping of Functionality
Recurring methods have been moved into aptly named interfaces (
And
,Columns
,OrderBy
, ...). This allows for a cleaner grouping of related functionality. This makes it easier for us to streamline behaviour between various ways to express the same thing (SELECT.from(x, COLUMNS)
,SELECT.from(x).columns(COLUMNS)
, etc).Interface Declaration Merging
Query flavours that should offer methods from the interfaces mentioned above can just pull them in via declaration merging:
Stricter Types
Types have been strictened where possible. Especially
.columns
and its various manifestations now try to actually derive the columns from valid properties:The same has been attempted for
.where
/.having
. Best we can offer there is a sporadic error when the parameters are total bogus.