Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(authentication): add updateProfile method #277

Merged
merged 6 commits into from
Dec 17, 2022

Conversation

trancee
Copy link
Contributor

@trancee trancee commented Dec 12, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • The changes have been tested successfully.
  • A changeset has been created (npm run changeset).

Close #28

@robingenz
Copy link
Member

LGTM

@trancee
Copy link
Contributor Author

trancee commented Dec 13, 2022

@robingenz I am trying to fix the path in the README.md file where you give an example how to use capacitor.config.ts:

/// <reference types="@capacitor/firebase-authentication" />

This seems wrong as it should be

/// <reference types="@capacitor-firebase/authentication" />

But fixing this directly in the README.md will revert it back to the wrong one once I called npm verify:web. I have not found where it adds this line, maybe you could fix it?

@robingenz
Copy link
Member

@trancee This is an open issue which i already reported: ionic-team/capacitor-docgen#40
You can just leave it this way for now. I hope it gets fixed soon.

@robingenz robingenz changed the title feat(authentication): add method updateProfile feat(authentication): add updateProfile method Dec 13, 2022
@trancee trancee marked this pull request as draft December 16, 2022 19:50
@trancee trancee marked this pull request as ready for review December 16, 2022 19:50
@trancee
Copy link
Contributor Author

trancee commented Dec 17, 2022

@robingenz I was wondering, when the updateProfile method successfully updated the profile, there is no authStateChanged event emitted and it is not clear what the current state of the profile is. Do you know if it is meant that way, or do we have to call something like getProfile to receive the latest update of the profile?

@robingenz
Copy link
Member

robingenz commented Dec 17, 2022

@robingenz I was wondering, when the updateProfile method successfully updated the profile, there is no authStateChanged event emitted and it is not clear what the current state of the profile is. Do you know if it is meant that way, or do we have to call something like getProfile to receive the latest update of the profile?

You should call getCurrentUser(...) to retrieve the users profile (see Firebase docs).

.changeset/warm-eyes-float.md Outdated Show resolved Hide resolved
packages/authentication/src/definitions.ts Outdated Show resolved Hide resolved
packages/authentication/src/definitions.ts Outdated Show resolved Hide resolved
Copy link
Member

@robingenz robingenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@trancee Thank you for your contribution again!

@robingenz robingenz merged commit d31f96f into capawesome-team:main Dec 17, 2022
@github-actions github-actions bot mentioned this pull request Dec 17, 2022
Paso pushed a commit to ice-cream-club/capacitor-firebase that referenced this pull request Apr 19, 2023
* docs

* feat(android): implement updateProfile

* docs: add changeset

* feat(ios): implement updateProfile

* fix(review)

* fix(review)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(authentication): add method updateProfile
2 participants