BlendLayers Shader Feature Updates #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well done Ryan, the effects are really cool, keep up the good work. I will merge your PR and do a local code review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry it took a while, but I managed to get in a bunch of new features and fixed some previous issues.
I'll also make a video or another post with more details tomorrow when I have time, that way I can demonstrate the new features and show how to use all of the new params and apply effects to dynamic layers in the new TestCharacterEffect3 demo.
I also ran into an issue with the BloomFilter not working with emissive values from a blended layer, since the PBRGlow.frag shader uses the initial emissiveMap for bloom and ignores any changes to the final emissve value that get made by the blend layers in this shader. So that might require a unique fragment shader written for Bloom with this shader, but hopefully I can find an easier solution than that.
Let me know if anything looks wrong or if you have any issues merging this code, but I think I did it right this time so it should be consistent with your current master branch.