added test case for None columns #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taylorfturner
requested review from
ssharpe42,
tazitoo,
taylorfturner,
micdavis,
ksneab7 and
danielbarcklow
auto-merge was automatically disabled
August 9, 2023 19:43
Head branch was pushed to by a user without write access
taylorfturner
approved these changes
Aug 9, 2023
taylorfturner
approved these changes
Aug 9, 2023
ksneab7
approved these changes
Aug 9, 2023
| @@ -108,7 +108,7 @@ def _generate_uncorrelated_column_data(self, num_samples): | |||
|
|
|||
| if not generator_name: | |||
| logging.warning( | |||
| f"Generator is {generator_name}. Null entries are not implemented." | |||
| f"Generator of type {generator_name} is not implemented." | |||
taylorfturner
merged commit c55f906
into
capitalone:feature/simple-tabular-generator
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added edge case test for a
Nonetype column in uncorrelated dataset generation