Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#1394] Update angular jest environment describe to say Angular #1395

Merged
merged 1 commit into from
Apr 7, 2024
Merged

fix: [#1394] Update angular jest environment describe to say Angular #1395

merged 1 commit into from
Apr 7, 2024

Conversation

TreyVigus
Copy link
Contributor

Previously, the describe block in Angular.test.ts was named React. This PR names it to Angular.

Addresses this Issue

capricorn86
capricorn86 approved these changes Apr 7, 2024
View reviewed changes
Copy link
Owner

@capricorn86 capricorn86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @TreyVigus! ⭐

@capricorn86 capricorn86 merged commit c29f36c into capricorn86:master Apr 7, 2024
4 checks passed
@capricorn86
Copy link
Owner

I changed the release type from "fix" to "chore" as it doesn't affect the consumer (it will not show up in the release notes).

@TreyVigus TreyVigus deleted the update-mislabelled-angular-jest-env-test branch April 27, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@capricorn86 capricorn86 capricorn86 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TreyVigus @capricorn86