Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#759@patch: Spurious HTML comments in embedded scripts. #760

Conversation

fcapolini
Copy link
Contributor

Solves #759, added test case in DOMParser.test.ts.

Copy link
Owner

@capricorn86 capricorn86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution! 🌟 I just have a small comment.

packages/happy-dom/src/xml-parser/XMLParser.ts Outdated Show resolved Hide resolved
Copy link
Owner

@capricorn86 capricorn86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry selected approved, but meant to select request changes

@capricorn86 capricorn86 merged commit 3631cef into capricorn86:master Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants