#700@minor: Add event listener options. #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
capricorn86
requested changes
Feb 18, 2023
| @@ -723,7 +723,7 @@ export default class Document extends Node implements IDocument { | |||
| this._isFirstWriteAfterOpen = true; | |||
|
|
|||
| for (const eventType of Object.keys(this._listeners)) { | |||
| const listeners = this._listeners[eventType]; | |||
| const listeners = this._listeners[eventType].map((listener) => listener.fn); | |||
There was a problem hiding this comment.
I think we can speed this up a bit by checking directly in the for loop instead as we can avoid the extra loop with the map().
| @@ -32,7 +41,8 @@ export default abstract class EventTarget implements IEventTarget { | |||
| listener: ((event: Event) => void) | IEventListener | |||
| ): void { | |||
| if (this._listeners[type]) { | |||
| const index = this._listeners[type].indexOf(listener); | |||
| const _listeners = this._listeners[type].map((l) => l.fn); | |||
There was a problem hiding this comment.
For loops are faster than map(), so I think we are better of with a for loop here, but we could improve performance even further if we store options and listeners in separate objects.
Example:
public readonly _options: {
[k: string]: { once: boolean }[];
} = {};
public readonly _listeners: {
[k: string]: (((event: Event) => void) | IEventListener)[];
} = {};
public addEventListener(
type: string,
listener: ((event: Event) => void) | IEventListener,
options?: { once: boolean }
): void {
this._listeners[type] = this._listeners[type] || [];
this._options[type] = this._options[type] || [];
this._listeners[type].push(listener);
this._options[type].push(options || null);
}
…and options in separate objects.
capricorn86
approved these changes
Feb 19, 2023
|
@btea I made a commit with the proposed adjustments for improved performance. Please have a look if you want 🙂 |
|
It looks very good. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rel #700