Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#898@minor: Change deprecated shadowroot attribute to shadowrootmode. #899

Merged
merged 2 commits into from
May 11, 2023
Merged

#898@minor: Change deprecated shadowroot attribute to shadowrootmode. #899

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4d90214
#898@minor: Change deprecated shadowroot attribute to shadowrootmode.
crypto-scythe May 7, 2023
b23d564
Merge branch 'master' into task/898-shadowroot-changed-to-shadowrootmode
capricorn86 May 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/happy-dom/src/xml-serializer/XMLSerializer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export default class XMLSerializer {
}

if (options?.includeShadowRoots && element.shadowRoot) {
innerHTML += `<template shadowroot="${element.shadowRoot.mode}">`;
innerHTML += `<template shadowrootmode="${element.shadowRoot.mode}">`;

for (const node of element.shadowRoot.childNodes) {
innerHTML += this.serializeToString(node, options);
Expand Down
2 changes: 1 addition & 1 deletion packages/happy-dom/test/xml-serializer/XMLSerializer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ describe('XMLSerializer', () => {
<div>
<custom-element key1="value1" key2="value2">
<span>Slotted content</span>
<template shadowroot="open">
<template shadowrootmode="open">
<style>
:host {
display: block;
Expand Down