Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add naive scrollHeight implementation #991

Merged
merged 1 commit into from
Aug 3, 2023

Conversation

lukaselmer
Copy link
Contributor

Very naive implementation of https://developer.mozilla.org/en-US/docs/Web/API/Element/scrollHeight

To be able to test https://mui.com/material-ui/react-textarea-autosize/ without warnings:

Warning: `NaN` is an invalid value for the `height` css style property.
    at textarea
    at TextareaAutosize (node_modules/@mui/base/node/TextareaAutosize/TextareaAutosize.js:41:7)
    at node_modules/@emotion/react/dist/emotion-element-b63ca7c6.cjs.dev.js:43:23
    at div
    at node_modules/@emotion/react/dist/emotion-element-b63ca7c6.cjs.dev.js:43:23
    at InputBase (node_modules/@mui/material/node/InputBase/InputBase.js:224:44)
    at OutlinedInput (node_modules/@mui/material/node/OutlinedInput/OutlinedInput.js:129:44)
    at div
    [...]

Copy link
Owner

@capricorn86 capricorn86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @lukaselmer! 🌟

The code is approved, but in order to merge, the commit message needs to follow the Contributing Guidelines. This is why the build is failing.

@lukaselmer
Copy link
Contributor Author

lukaselmer commented Aug 2, 2023

Thanks for the review and the heads up @capricorn86 👍 I changed the commit message according to the Contributing Guidelines. The pipeline is green now =)

@capricorn86 capricorn86 merged commit 9221b75 into capricorn86:master Aug 3, 2023
1 check passed
capricorn86 pushed a commit to maxmilton/happy-dom that referenced this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants