Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make build reproducible for capstone_sys #152

Closed
chenhdc opened this issue Feb 6, 2024 · 3 comments
Closed

make build reproducible for capstone_sys #152

chenhdc opened this issue Feb 6, 2024 · 3 comments

Comments

@chenhdc
Copy link
Contributor

chenhdc commented Feb 6, 2024

Hi, we found libcapstone_sys.rlib varies from filesystem readdir order. Probably from the read_dir in

read_dir(dir)
. fs::read_dir()'s behavior is platform-specific.
We found https://github.com/gyscos/zstd-rs/pull/162 resolves a similar issue in another lib. Please make build reproducible for capstone_sys.

@tmfink
Copy link
Member

tmfink commented Feb 16, 2024

Fixed by #153

@tmfink tmfink closed this as completed Feb 16, 2024
@chenhdc
Copy link
Contributor Author

chenhdc commented Feb 18, 2024

@tmfink when fix this issue, could publish a new release?

@tmfink
Copy link
Member

tmfink commented Feb 25, 2024

@tmfink when fix this issue, could publish a new release?

capstone-sys v0.16.0 and capstone v0.12.0 were just published

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants