migrate from failure to anyhow + thiserror #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #127 +/- ##
==========================================
- Coverage 68.60% 68.57% -0.03%
==========================================
Files 65 65
Lines 5902 5906 +4
==========================================
+ Hits 4049 4050 +1
- Misses 1853 1856 +3
Continue to review full report at Codecov.
|
zeeshanlakhani
approved these changes
Feb 22, 2021
There was a problem hiding this comment.
I have a pretty minor comment on #80 that would change this, but this is super straightforward. Having using anyhow in another project, this totally is what I/we expected and doesn't mean a ton of changes.
drunkirishcoder
force-pushed
the
djin/anyhow-anywho
branch
from
c66cd6d
to
ec524ec
Compare
|
I do ❤️ ocd @drunkirishcoder |
zeeshanlakhani
approved these changes
Feb 24, 2021
| display = "Struct size {} exceeds the remaining buffer length {}.", | ||
| _0, _1 | ||
| )] | ||
| #[error("Struct size {0} exceeds the remaining buffer length {1}.")] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes RUSTSEC-2020-0036.
There are a few options but seems like
anyhowis the most active and it's a pretty easy drop in replacement for error propagation. The derive macro is replaced withthiserror. Together that covers all the ways we were usingfailurecrate.Type of change
maintenance chore