6 to 4 & 4 to 6 installs #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
=======================================
Coverage 66.50% 66.50%
=======================================
Files 60 60
Lines 4621 4621
=======================================
Hits 3073 3073
Misses 1548 1548 Continue to review full report at Codecov.
|
zeeshanlakhani
force-pushed
the
zl/nat6to4-fix
branch
from
56c09f2
to
77d9ec9
Compare
drunkirishcoder
requested changes
May 1, 2020
examples/nat64/main.rs
Outdated
| @@ -150,28 +150,20 @@ fn nat_6to4(ethernet: Ethernet) -> Fallible<Either<Ethernet>> { | |||
| } | |||
| } | |||
|
|
|||
| fn install(qs: HashMap<String, PortQueue>) -> impl Pipeline { | |||
| fn install_6_to_4(qs: HashMap<String, PortQueue>) -> impl Pipeline { | |||
| Poll::new(qs["eth1"].clone()) | |||
| .map(|packet| packet.parse::<Ethernet>()) | |||
There was a problem hiding this comment.
this map can be moved into the nat fn. alternatively move the ipv6 parse out of that fn. it's a little inconsistent to be parsing in 2 different places like this.
examples/nat64/main.rs
Outdated
| @@ -150,28 +150,20 @@ fn nat_6to4(ethernet: Ethernet) -> Fallible<Either<Ethernet>> { | |||
| } | |||
| } | |||
|
|
|||
| fn install(qs: HashMap<String, PortQueue>) -> impl Pipeline { | |||
| fn install_6_to_4(qs: HashMap<String, PortQueue>) -> impl Pipeline { | |||
There was a problem hiding this comment.
name to 6to4 to stay consistent with the other name.
examples/nat64/README.md
Outdated
| @@ -53,7 +53,7 @@ The **NAT64** gateway is configured with two ports. `eth1` is the port connected | |||
| txd = 512 | |||
| ``` | |||
|
|
|||
| Because they are assigned the same core, we can install a pipeline that forwards packets received on `eth1` through `eth2` by using `add_pipeline_to_core`. | |||
| Because they are assigned the same core, we can install pipelines that forward packets received on `eth1` through `eth2` and `eth2` to `eth1` by using `add_pipeline_to_core`. | |||
There was a problem hiding this comment.
an extra space here in front of "and"
zeeshanlakhani
force-pushed
the
zl/nat6to4-fix
branch
from
77d9ec9
to
295c52c
Compare
zeeshanlakhani
force-pushed
the
zl/nat6to4-fix
branch
from
295c52c
to
5d199e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
two pipelines for eth1 -> eth2 and eth2 -> eth1
Type of change