feat: Improve e-sign request flow and email logic #285

Raju-kadel-27 · 2024-05-01T09:19:22Z

PR for issue #273

github-actions · 2024-05-01T09:19:38Z

Thank you for following the naming conventions for pull request titles! 🙏

Raju-kadel-27 · 2024-05-02T08:27:44Z

@dahal I think it's ready for review.

G3root

Great work as always ❤️ 🚀 🚀 .

Here are some of my feedback and suggestions:

Save as a draft is not working.
optional message should be saved in the template model because ordered signing needs those values.
Maybe we can have an input for a custom email subject as well. We can save those optional values in the template model like "optional message" => emailBody and emailSubject. cc @dahal.
@dahal, should we allow optional message to be added to the draft as well? If so, rather than rendering a dropdown for Save & Continue, we can render a Popover that has all the inputs above and provide the user the option to complete or save as a draft.

G3root · 2024-05-03T02:34:32Z

src/trpc/routers/template-field-router/schema.ts

+  emailPayload: z.object({
+    optionalMessage: z.string().optional(),
+    expiryDate: z.date().or(z.null()).or(z.string()).optional(),
+    documentName: z.string(),


documentName,companyName, completedOn and companyLogo should be queried from the backend no need to pass it on from the frontend

@G3root Sure ! Thanks for the feedback.

documentName,companyName, completedOn and companyLogo should be queried from the backend no need to pass it on from the frontend

I second that.

G3root · 2024-05-03T02:46:52Z

src/components/template/canavs-toolbar/index.tsx

+  const closeModal = watch("closeModal");
+
+  // close modal is triggered from template-field-provider
+  useEffect(() => {


This useEffect should be avoided, and we don't need closeModal. This would lead to some unexpected bugs and boilerplate code because we are syncing two states through a useEffect. a form submit would close the modal.

G3root · 2024-05-03T02:53:17Z

src/providers/template-field-provider.tsx

  recipient: z.string(),
  recipientColors: z.record(z.string()),
+  emailPayload: z.object({
+    optionalMessage: z.string().optional(),
+    expiryDate: z.date().or(z.null()).or(z.string()).optional(),


how are we handling expiryDate ? is it being used in the backend ?

Currently we are just displaying it in email body only.
Do not have a clear idea. (Might be just for the information purpose)

We will have the expiry on second iteration, lets remove for now

dahal

Looking good, please go through the reviews and make necessary changes.

dahal · 2024-05-03T06:14:15Z

package.json

@@ -130,6 +130,6 @@
    "initVersion": "7.25.1"
  },
  "trigger.dev": {
-    "endpointId": "captable-A0-I"
+    "endpointId": "opencap-WhPZ"


Do we need to hardcode this? Each contributors and env will have different ids

No, i will fix it.

dahal · 2024-05-03T06:15:08Z

public/avatar.svg

We already have /public/placeholders/user.svg, please remove this.

dahal · 2024-05-03T06:15:58Z

public/signature.svg

Please remove this, and if we need re-usable icon, create one on icons.tsx

dahal · 2024-05-03T06:16:29Z

src/components/esign/optional-message-modal.tsx

+          name: payload.company.name,
+          logo:
+            payload.company.logo ??
+            "https://avatars.githubusercontent.com/u/163377635?s=48&v=4",


Why is this hardcoded?

dahal · 2024-05-03T06:17:04Z

src/emails/EsignEmail.tsx

+                <Column align="left">
+                  <Img
+                    className="rounded-full"
+                    src={"https://www.svgrepo.com/show/437226/signature.svg"}


Please dont hardcode these

dahal · 2024-05-03T06:17:46Z

src/emails/EsignEmail.tsx

                href={signingLink}
              >
-                Sign document
+                Esign the template


Suggested change

Esign the template

Sign the document

dahal · 2024-05-03T06:18:42Z

src/emails/EsignEmail.tsx

-export default EsignEmail;
+            <Hr className="mx-0 my-[26px] w-full border border-solid border-neutral-200" />
+            <Text className="mx-auto text-center text-[12px] leading-[24px] text-[#666666]">
+              If you were not expecting this email, you can ignore this email.


Suggested change

If you were not expecting this email, you can ignore this email.

Please ignore, if you were not expecting this email.

dahal · 2024-05-03T06:20:58Z

src/lib/utils.ts

+  return hour > 12;
+}
+
+export function getSanitizedDateTime(datetime: string) {


Please use @/common/dayjs to sanitize these dates and timestamps

dahal · 2024-05-03T06:25:30Z

src/providers/template-field-provider.tsx

  recipient: z.string(),
  recipientColors: z.record(z.string()),
+  emailPayload: z.object({
+    optionalMessage: z.string().optional(),
+    expiryDate: z.date().or(z.null()).or(z.string()).optional(),


We will have the expiry on second iteration, lets remove for now

dahal · 2024-05-03T06:26:55Z

src/trpc/routers/template-field-router/procedures/add-fields.ts

+        return {
+          success: false,
+          message: "Email requires sender name , email and company logo.",
+        };


Let's not make company logo a requirement to eSign. We have a placeholder we can use if company logo is not available.

/public/placeholders/company.svg

dahal · 2024-05-03T06:31:49Z

Here are my thoughts

optional message should be saved in the template model because ordered signing needs those values.

Yes, optional message should be on template model

Maybe we can have an input for a custom email subject as well. We can save those optional values in the template model like "optional message" => emailBody and emailSubject. cc @dahal.

For now, we can just limit to message and we can add subject, expiry and other optional fields on second iteration.

@dahal, should we allow optional message to be added to the draft as well? If so, rather than rendering a dropdown for Save & Continue, we can render a Popover that has all the inputs above and provide the user the option to complete or save as a draft.

We dont need to allow optional message on draft. Regarding popover, i have been experimenting it on Data room, i kind of like it. But for this use case, since modal is already implemented, lets limit message to Send for signature button.

fix: fix conflicts in add-fields-procedure

fix: conflict in get-signing-fields

Raju-kadel-27 · 2024-05-04T06:04:21Z

@dahal @G3root Fixed it.

Raju-kadel-27 marked this pull request as ready for review May 2, 2024 08:24

dahal mentioned this pull request May 2, 2024

Add additional input types on signature template #284

Closed

G3root self-requested a review May 3, 2024 02:27

G3root requested changes May 3, 2024

View reviewed changes

dahal requested changes May 3, 2024

View reviewed changes

Raju-kadel-27 added 22 commits May 4, 2024 09:34

feat: zod schema for sending-esign-emails

7f2478c

feat: modal for optional message and expiry date input

f2f282e

feat: background job via trigger.dev for sending e-sign emails

bd636ca

feat: utility functions for date-time extraction

2ebf075

feat: zod schemas updated in template-field for extending email logic

07e0e08

feat: extended logic for emailing in previous code

7333467

fix: fix conflicts in add-fields-procedure

feat: email template for requesting e-signature

4197158

chore: some schema refactoring

89b9249

feat: handling modal and some submit ref logic

8476509

feat: extended submission logic on send-signature-action

e1b8bf1

feat: added form-schema for react-hook-form

29f48b4

feat: some improvements in the page

a63ed81

feat: some svgs added in public directory

f1094d9

fix: some minor refactoring

053b77f

feat: more fields selection from get-template procedure

1d9c473

feat: callback function that submit the form

1ea75ed

fix: some improvements in optional message modal

9815726

chore: provide relevant safe document name for understanding

8a341e6

feat: added packages

b571d60

feat: minor refactoring for build fix

ac09aee

fix: conflict in get-signing-fields

fix: svgs deleted from public directory

6b4c0ec

fix: improved logic , save-to-draft-fix and error handling

d35add4

Raju-kadel-27 added 12 commits May 4, 2024 09:48

chore: schema refactoring of add-field-procedure

ee655d1

fix: minor improvements on client side

d27cc9a

feat: include optional message field in template table

d362bc0

feat: added signature and arrow-right reusable icons

24e5eae

fix: minor improvements on background job and email template

e005b0d

fix: minor refactoring

f0932e4

feat: optionalMessage column added in prisma schema

b9a81de

fix: trigger dev endpoint id switched back to repo id

9e92f69

chore: removed unwanted data from db

11322d4

fix: needed improvements for encode/decode email token

86d26e4

fix: needed improvements for get-signing-field procedure

b3f95c2

fix: minor formatting

23f0156

Raju-kadel-27 force-pushed the feat/improve-esign-request-flow-and-email branch from aa0a2a3 to 23f0156 Compare May 4, 2024 05:54

feat: change column name and reformat

971e083

dahal force-pushed the feat/improve-esign-request-flow-and-email branch from 24a3b2e to 971e083 Compare May 4, 2024 08:38

Raju-kadel-27 closed this May 4, 2024

Raju-kadel-27 deleted the feat/improve-esign-request-flow-and-email branch May 4, 2024 15:58

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Improve e-sign request flow and email logic #285

feat: Improve e-sign request flow and email logic #285

Raju-kadel-27 commented May 1, 2024

github-actions bot commented May 1, 2024 •

edited

Loading

Raju-kadel-27 commented May 2, 2024

G3root left a comment

G3root May 3, 2024

Raju-kadel-27 May 3, 2024

dahal May 3, 2024

G3root May 3, 2024

G3root May 3, 2024

Raju-kadel-27 May 3, 2024 •

edited

Loading

dahal May 3, 2024

dahal left a comment

dahal May 3, 2024

Raju-kadel-27 May 3, 2024

dahal May 3, 2024

dahal May 3, 2024

dahal May 3, 2024

dahal May 3, 2024

dahal May 3, 2024

dahal May 3, 2024

dahal May 3, 2024

dahal May 3, 2024

dahal May 3, 2024

dahal commented May 3, 2024

Raju-kadel-27 commented May 4, 2024

	If you were not expecting this email, you can ignore this email.
	Please ignore, if you were not expecting this email.

feat: Improve e-sign request flow and email logic #285

feat: Improve e-sign request flow and email logic #285

Conversation

Raju-kadel-27 commented May 1, 2024

github-actions bot commented May 1, 2024 • edited Loading

Raju-kadel-27 commented May 2, 2024

G3root left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Raju-kadel-27 May 3, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dahal left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dahal commented May 3, 2024

Raju-kadel-27 commented May 4, 2024

github-actions bot commented May 1, 2024 •

edited

Loading

Raju-kadel-27 May 3, 2024 •

edited

Loading