Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Discriminator #15 #25

Merged
merged 2 commits into from
Jun 30, 2019
Merged

Added Discriminator #15 #25

merged 2 commits into from
Jun 30, 2019

Conversation

captain-pool
Copy link
Owner

Added VGG 128 Discriminator
Issue: #15

@captain-pool captain-pool added the ESRGAN Issue related to ESRGAN label Jun 28, 2019
Copy link
Collaborator

@srjoglekar246 srjoglekar246 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a followup, lets polish the code written so far to the standards in the TF Hub code :-).

E2_ESRGAN/lib/model.py Show resolved Hide resolved
@@ -46,3 +45,29 @@ def call(self, input_):
feature = self.lrelu(self.conv_last_1(feature))
out = self.conv_last_2(feature)
return out


class VGGArch(tf.keras.Model):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets add docstrings, here and to the previous class.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've addressed adding docstrings as one of the tasks, #23, Will be adding them when I address this PR. What do you suggest?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SG.

@captain-pool captain-pool merged commit bb51b4f into master Jun 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ESRGAN Issue related to ESRGAN
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants