-
-
Notifications
You must be signed in to change notification settings - Fork 87
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
In order to make sure all conditions must apply to execute an action the logical AND and OR conditions can combin multiple condition into a single condition.
- Loading branch information
1 parent
832a516
commit 77a2b75
Showing
9 changed files
with
431 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
<?php | ||
|
||
/** | ||
* This file is part of CaptainHook. | ||
* | ||
* (c) Sebastian Feldmann <sf@sebastian-feldmann.info> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
declare(strict_types=1); | ||
|
||
namespace CaptainHook\App\Hook\Condition; | ||
|
||
use CaptainHook\App\Hook\Condition; | ||
|
||
/** | ||
* Logical condition base class | ||
* | ||
* @package CaptainHook | ||
* @author Sebastian Feldmann <sf@sebastian-feldmann.info> | ||
* @author Andreas Heigl <andreas@heigl.org> | ||
* @link https://github.com/captainhookphp/captainhook | ||
* @since Class available since Release 5.7.0 | ||
*/ | ||
abstract class Logic implements Condition | ||
{ | ||
/** | ||
* List of conditions to logically connect | ||
* | ||
* @var \CaptainHook\App\Hook\Condition[] | ||
*/ | ||
protected $conditions = []; | ||
|
||
final private function __construct(Condition ...$conditions) | ||
{ | ||
$this->conditions = $conditions; | ||
} | ||
|
||
/** | ||
* Create a logic condition | ||
* | ||
* @param array $conditions | ||
* @return \CaptainHook\App\Hook\Condition | ||
*/ | ||
public static function fromConditionsArray(array $conditions): Condition | ||
{ | ||
$realConditions = []; | ||
foreach ($conditions as $condition) { | ||
if (! $condition instanceof Condition) { | ||
continue; | ||
} | ||
$realConditions[] = $condition; | ||
} | ||
|
||
return new static(...$realConditions); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
<?php | ||
|
||
/** | ||
* This file is part of CaptainHook | ||
* | ||
* (c) Sebastian Feldmann <sf@sebastian-feldmann.info> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
declare(strict_types=1); | ||
|
||
namespace CaptainHook\App\Hook\Condition\Logic; | ||
|
||
use CaptainHook\App\Console\IO; | ||
use CaptainHook\App\Hook\Condition\Logic; | ||
use SebastianFeldmann\Git\Repository; | ||
|
||
/** | ||
* Connects multiple conditions with 'and' | ||
* | ||
* @package CaptainHook | ||
* @author Sebastian Feldmann <sf@sebastian-feldmann.info> | ||
* @author Andreas Heigl <andreas@heigl.org> | ||
* @link https://github.com/captainhookphp/captainhook | ||
* @since Class available since Release 5.7.0 | ||
*/ | ||
final class LogicAnd extends Logic | ||
{ | ||
public function isTrue(IO $io, Repository $repository): bool | ||
{ | ||
foreach ($this->conditions as $condition) { | ||
if (false === $condition->isTrue($io, $repository)) { | ||
return false; | ||
} | ||
} | ||
return true; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
<?php | ||
|
||
/** | ||
* This file is part of CaptainHook | ||
* | ||
* (c) Sebastian Feldmann <sf@sebastian-feldmann.info> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
declare(strict_types=1); | ||
|
||
namespace CaptainHook\App\Hook\Condition\Logic; | ||
|
||
use CaptainHook\App\Console\IO; | ||
use CaptainHook\App\Hook\Condition\Logic; | ||
use SebastianFeldmann\Git\Repository; | ||
|
||
/** | ||
* Connects multiple conditions with 'or' | ||
* | ||
* @package CaptainHook | ||
* @author Sebastian Feldmann <sf@sebastian-feldmann.info> | ||
* @author Andreas Heigl <andreas@heigl.org> | ||
* @link https://github.com/captainhookphp/captainhook | ||
* @since Class available since Release 5.7.0 | ||
*/ | ||
final class LogicOr extends Logic | ||
{ | ||
public function isTrue(IO $io, Repository $repository): bool | ||
{ | ||
foreach ($this->conditions as $condition) { | ||
if (true === $condition->isTrue($io, $repository)) { | ||
return true; | ||
} | ||
} | ||
return false; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
<?php | ||
|
||
/** | ||
* This file is part of CaptainHook. | ||
* | ||
* (c) Sebastian Feldmann <sf@sebastian-feldmann.info> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace CaptainHook\App\Hook\Condition\Logic; | ||
|
||
use CaptainHook\App\Console\IO\Mockery as IOMockery; | ||
use CaptainHook\App\Hook\Condition; | ||
use CaptainHook\App\Mockery as AppMockery; | ||
use PHPUnit\Framework\TestCase; | ||
|
||
class LogicalAndTest extends TestCase | ||
{ | ||
use IOMockery; | ||
use AppMockery; | ||
|
||
/** | ||
* @covers \CaptainHook\App\Hook\Condition\Logic\LogicAnd::isTrue | ||
* @covers \CaptainHook\App\Hook\Condition\Logic\LogicAnd::fromConditionsArray | ||
*/ | ||
public function testLogicAndReturnsFalseWithOneFailure(): void | ||
{ | ||
$io = $this->createIOMock(); | ||
$repository = $this->createRepositoryMock(); | ||
$true = $this->getMockBuilder(Condition::class)->getMock(); | ||
$false = $this->getMockBuilder(Condition::class)->getMock(); | ||
|
||
$true->method('isTrue')->willReturn(true); | ||
$false->method('isTrue')->willReturn(false); | ||
|
||
$condition = LogicAnd::fromConditionsArray([$true, $false]); | ||
|
||
$this->assertFalse($condition->isTrue($io, $repository)); | ||
} | ||
|
||
/** | ||
* @covers \CaptainHook\App\Hook\Condition\Logic\LogicAnd::isTrue | ||
* @covers \CaptainHook\App\Hook\Condition\Logic\LogicAnd::fromConditionsArray | ||
*/ | ||
public function testLogicAndReturnsTrueWithAllSuccess(): void | ||
{ | ||
$io = $this->createIOMock(); | ||
$repository = $this->createRepositoryMock(); | ||
$true = $this->getMockBuilder(Condition::class)->getMock(); | ||
|
||
$true->method('isTrue')->willReturn(true); | ||
|
||
$condition = LogicAnd::fromConditionsArray([$true, $true, $true]); | ||
|
||
$this->assertTrue($condition->isTrue($io, $repository)); | ||
} | ||
|
||
/** | ||
* @covers \CaptainHook\App\Hook\Condition\Logic\LogicAnd::fromConditionsArray | ||
*/ | ||
public function testNamedConstructorIgnoresNonCondition(): void | ||
{ | ||
$io = $this->createIOMock(); | ||
$repository = $this->createRepositoryMock(); | ||
$true = $this->getMockBuilder(Condition::class)->getMock(); | ||
$true->expects($this->exactly(2))->method('isTrue')->willReturn(true); | ||
|
||
$condition = LogicAnd::fromConditionsArray([$true, 'string', $true]); | ||
|
||
$this->assertTrue($condition->isTrue($io, $repository)); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
<?php | ||
|
||
/** | ||
* This file is part of CaptainHook. | ||
* | ||
* (c) Sebastian Feldmann <sf@sebastian-feldmann.info> | ||
* | ||
* For the full copyright and license information, please view the LICENSE | ||
* file that was distributed with this source code. | ||
*/ | ||
|
||
namespace CaptainHook\App\Hook\Condition\Logic; | ||
|
||
use CaptainHook\App\Console\IO\Mockery as IOMockery; | ||
use CaptainHook\App\Hook\Condition; | ||
use CaptainHook\App\Mockery as AppMockery; | ||
use PHPUnit\Framework\TestCase; | ||
|
||
class LogicalOrTest extends TestCase | ||
{ | ||
use IOMockery; | ||
use AppMockery; | ||
|
||
/** | ||
* @covers \CaptainHook\App\Hook\Condition\Logic\LogicOr::isTrue | ||
* @covers \CaptainHook\App\Hook\Condition\Logic\LogicOr::fromConditionsArray | ||
*/ | ||
public function testLogicOrReturnsTrueWithOneFailure(): void | ||
{ | ||
$io = $this->createIOMock(); | ||
$repository = $this->createRepositoryMock(); | ||
$true = $this->getMockBuilder(Condition::class)->getMock(); | ||
$false = $this->getMockBuilder(Condition::class)->getMock(); | ||
|
||
$true->method('isTrue')->willReturn(true); | ||
$false->method('isTrue')->willReturn(false); | ||
|
||
$condition = LogicOr::fromConditionsArray([$false, $true]); | ||
|
||
$this->assertTrue($condition->isTrue($io, $repository)); | ||
} | ||
|
||
/** | ||
* @covers \CaptainHook\App\Hook\Condition\Logic\LogicOr::isTrue | ||
* @covers \CaptainHook\App\Hook\Condition\Logic\LogicOr::fromConditionsArray | ||
*/ | ||
public function testLogicOrReturnsFalseWithAllFailing(): void | ||
{ | ||
$io = $this->createIOMock(); | ||
$repository = $this->createRepositoryMock(); | ||
$false = $this->getMockBuilder(Condition::class)->getMock(); | ||
|
||
$false->method('isTrue')->willReturn(false); | ||
|
||
$condition = LogicOr::fromConditionsArray([$false, $false, $false]); | ||
|
||
$this->assertFalse($condition->isTrue($io, $repository)); | ||
} | ||
} |
Oops, something went wrong.