Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all the remaining MAKI classes #855

Merged
merged 1 commit into from
Aug 17, 2019

Conversation

jberg
Copy link
Collaborator

@jberg jberg commented Aug 17, 2019

Got tired of seeing the errors when trying new skins, so added all the remaining MAKI classes 🎉

Copy link
Owner

@captbaritone captbaritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

@captbaritone captbaritone merged commit e4fc867 into captbaritone:master Aug 17, 2019
@captbaritone
Copy link
Owner

@jberg How did you derive the ids for runtime/index.ts? I have a few more classes that we are missing, but I don't see an obvious way to derive the ID we use here from the ID we have in objects.ts. We have getFormattedId but I think that goes the other way.

captbaritone added a commit that referenced this pull request Sep 26, 2019
These still need to be added to runtime/index.ts I'm working on how to derive the IDs.

#855
captbaritone pushed a commit that referenced this pull request Nov 30, 2019
captbaritone added a commit that referenced this pull request Nov 30, 2019
These still need to be added to runtime/index.ts I'm working on how to derive the IDs.

#855
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants