Fix filename slashes #880
Merged
Fix filename slashes #880
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modern/src/utils.js
Outdated
| @@ -92,12 +97,11 @@ export async function inlineIncludes(xml, zip) { | |||
| return node; | |||
| } | |||
| // TODO: Normalize file names so that they hit the same cache | |||
| const includedFile = await readXml(zip, node.attributes.file); | |||
| const filename = fixFilenameSlashes(node.attributes.file); | |||
| const includedFile = await readXml(zip, filename); | |||
There was a problem hiding this comment.
I think this would lead to us double escaping.
There was a problem hiding this comment.
Oh derp, missed that readXml already calls getCaseInsensitveFile. Won't double escape, since we are just replacing, but doesn't need to be in both places!
Thanks
captbaritone
pushed a commit
that referenced
this pull request
Nov 30, 2019
* Fix windows filename slashes * add comment * readXml will already convert the slashes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.