Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing experiment and treamtent labels from experiment engine metrics #141

Merged

Conversation

leonlnj
Copy link
Contributor

@leonlnj leonlnj commented Dec 3, 2021

This PR removes the experiment and treatments for experiment engine metrics.

The flexibility to allow experiment engine to log additional labels which might cause a huge cardinality.

Also, it is recommended not use dimensions with high cardinality -
https://prometheus.io/docs/practices/naming/
https://www.robustperception.io/cardinality-is-key

CAUTION: Remember that every unique combination of key-value label pairs represents a new time series, 
which can dramatically increase the amount of data stored.
Do not use labels to store dimensions with high cardinality (many different label values), 
such as user IDs, email addresses, or other unbounded sets of values.

@leonlnj leonlnj self-assigned this Dec 3, 2021
@leonlnj leonlnj requested a review from a team December 3, 2021 04:19
@leonlnj leonlnj marked this pull request as ready for review December 3, 2021 04:19
@leonlnj leonlnj merged commit dcaf313 into caraml-dev:main Dec 3, 2021
@leonlnj leonlnj mentioned this pull request Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants