Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not set knative resource percentage annotation if value <= 0 #145

Merged
merged 1 commit into from
Dec 15, 2021
Merged

Do not set knative resource percentage annotation if value <= 0 #145

merged 1 commit into from
Dec 15, 2021

Conversation

krithika369
Copy link
Collaborator

The annotation queue.sidecar.serving.knative.dev/resourcePercentage will not be set on the Knative service if the configured value is <= 0.

@krithika369 krithika369 requested a review from a team December 14, 2021 23:39
romanwozniak
romanwozniak approved these changes Dec 15, 2021
View reviewed changes
Copy link
Contributor

@romanwozniak romanwozniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@krithika369 krithika369 merged commit 5bb6c15 into caraml-dev:main Dec 15, 2021
@krithika369 krithika369 deleted the remove_queueproxy_resource_annotation branch December 15, 2021 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanwozniak romanwozniak romanwozniak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krithika369 @romanwozniak