Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assets for router versions. #163

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

ashwinath
Copy link
Contributor

@ashwinath ashwinath commented Jan 28, 2022

Fixes the assets missing from the Turing router history page.

Old:
Old

New:
This PR

Copy link
Collaborator

@krithika369 krithika369 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also help to run a check on the asset names and what's referenced in the docs/ folder? For example, in my local version of the code, I now have 63 hits for .png but only 50 images in the .gitbook/assets folder. Just wondering if we missed something else on the first import. Other than this, LGTM. Thank you!

@ashwinath
Copy link
Contributor Author

Could you also help to run a check on the asset names and what's referenced in the docs/ folder? For example, in my local version of the code, I now have 63 hits for .png but only 50 images in the .gitbook/assets folder. Just wondering if we missed something else on the first import. Other than this, LGTM. Thank you!

Some are used more than once so it won't be a 1:1 relation but rather a 1 png to many references relation.

@ashwinath ashwinath merged commit a716840 into caraml-dev:main Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants