Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Update navbar project URL #335

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

krithika369
Copy link
Collaborator

@krithika369 krithika369 commented Apr 20, 2023

With the Applications v2 API introduced in caraml-dev/mlp#72, the homepage URL is supposed to be read from the homepage property of the current app stored in the applications context, as opposed to .href. The MLP PR was integrated to Turing through the UI library bump done in #333. This PR updates the nav URL accordingly.

Screenshot 2023-04-20 at 11 40 19 AM

@krithika369 krithika369 requested a review from a team April 20, 2023 04:00
Copy link
Contributor

@deadlycoconuts deadlycoconuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@krithika369 krithika369 merged commit 58f6685 into caraml-dev:main Apr 20, 2023
@krithika369 krithika369 deleted the check_navbar_issue branch April 20, 2023 05:39
@krithika369 krithika369 added the type: bug Something isn't working label Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants