-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Onboard IBM Telemetry #1874
base: theiliad-v10-legacy
Are you sure you want to change the base?
Onboard IBM Telemetry #1874
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Project IDs and configs look good! I think we just need to uninstall the legacy @carbon/telemetry
packages now that they are no longer used in postinstall scripts.
It's interesting that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@IgnacioBecerra @ariellalgilmore this LGTM. I reviewed:
- Project IDs match the IDs used in the master branch
- YML config files have the right scopes and the React config file has the same JSX config as the master branch
- Postinstall scripts
- Readme notices
- The package.json's don't specify "files", so there's no need to include the package.json in those export lists
@theiliad I'm not sure if that Mend check can be ignored or not, but the changes in this PR LGTM to instrument the v10 packages. |
@mattrosno If there’s anything I need to do on my end, please let me know - I’m happy to help. |
@mattrosno @makafsal there isn't an automatic process to make 0.x releases, I will do it manually soon |
@theiliad following up as this it still open. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@makafsal Since we are still in the process of onboarding the v10
charts package with this PR, I attempted to push my own commits here, but due to lacking permissions, I am suggesting changes through a review instead.
We are looking to update the READMEs to the wording of the latest version, and also updating the .yml
files so we're using the new stable URL. Let me know if you have any question, thank you!
Co-authored-by: Ignacio Becerra <i1becerr@ucsd.edu>
Co-authored-by: Ignacio Becerra <i1becerr@ucsd.edu>
Co-authored-by: Ignacio Becerra <i1becerr@ucsd.edu>
Co-authored-by: Ignacio Becerra <i1becerr@ucsd.edu>
Co-authored-by: Ignacio Becerra <i1becerr@ucsd.edu>
Co-authored-by: Ignacio Becerra <i1becerr@ucsd.edu>
Co-authored-by: Ignacio Becerra <i1becerr@ucsd.edu>
Co-authored-by: Ignacio Becerra <i1becerr@ucsd.edu>
Co-authored-by: Ignacio Becerra <i1becerr@ucsd.edu>
Co-authored-by: Ignacio Becerra <i1becerr@ucsd.edu>
@IgnacioBecerra Great, I've committed those changes 🚀. If you have more changes to commit, don't hesitate to ping me in Slack✌️. |
Updates
packages/core/telemetry.yml
file@ibm/telemetry-js
packages/core/README.md