Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cv-toast-notification add more slots #1515

Merged
merged 2 commits into from
Sep 4, 2023
Merged

feat: cv-toast-notification add more slots #1515

merged 2 commits into from
Sep 4, 2023

Conversation

OlkaB
Copy link
Contributor

@OlkaB OlkaB commented Aug 14, 2023

Contributes to #1514

## What did you do?
Added more slots to CvToastNotification
btw. fixed toast notification close button class name

## Why did you do it?
To give more granular control over component content

How have you tested it?

added test suits to spec.js

Were docs updated if needed?

  • N/A
  • No
  • Yes

@davidnixon davidnixon self-assigned this Aug 19, 2023
Copy link
Collaborator

@davidnixon davidnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really nice fix. Thanks! Could you add a story showing how to use the slots?

@OlkaB
Copy link
Contributor Author

OlkaB commented Aug 30, 2023

done

Copy link
Collaborator

@davidnixon davidnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davidnixon davidnixon merged commit a94516f into carbon-design-system:vNext Sep 4, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants