Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figma efficiency: Fluid dropdown - Add as parameter under the style property #827

Open
Tracked by #833
benjamin-kurien opened this issue May 23, 2024 · 2 comments
Open
Tracked by #833

Comments

@benjamin-kurien
Copy link

benjamin-kurien commented May 23, 2024

Fluid can be updated as a a parameter under the dropdown style property

Benefits

  • Designers can easily toggle between multiple visual variants of dropdown without changing the component
  • Design system will be organised better, with lesser variant groups in the same page

Required steps

  1. Copy the fluid variants into the default dropdown component.
  2. Create & assign style & size properties to each fluid variant.
  3. Name both the style & size properties as fluid.
  4. Create any missing fluid variants required for any property combination.

Repeat same steps for combobox, multiselect and filterable.

@laurenmrice
Copy link
Member

laurenmrice commented Jun 27, 2024

@benjamin-kurien We need to list in the description of this issue the steps of "how to add as parameter under the style property" so it can be ready to size.

@sstrubberg sstrubberg removed this from the 2024 Q3 milestone Jul 11, 2024
@laurenmrice
Copy link
Member

Update from Backlog cleaning (08/19):

  • This needs to be looked at again to see if we can implement this in a scalable way for all components that have Fluid styles.
  • This is also will affect the code connect work, so we need to connect with Alison.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🪆 Needs Refined
Status: Later 🧊
Development

No branches or pull requests

3 participants