Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add notification tokens to color token page #4106

Closed
alisonjoseph opened this issue Jun 10, 2024 · 2 comments
Closed

docs: add notification tokens to color token page #4106

alisonjoseph opened this issue Jun 10, 2024 · 2 comments

Comments

@alisonjoseph
Copy link
Member

alisonjoseph commented Jun 10, 2024

The notification component tokens are missing from the Color > Tokens page

$notification-background-error
$notification-background-success
$notification-background-info
$notification-background-warning
$notification-action-hover
$notification-action-tertiary-inverse
$notification-action-tertiary-inverse-active
$notification-action-tertiary-inverse-hover
$notification-action-tertiary-inverse-text
$notification-action-tertiary-inverse-text-on-color-disabled

Values should be here https://github.com/carbon-design-system/carbon/blob/main/packages/styles/scss/components/notification/_tokens.scss

Related: We need a way to designate the difference between component tokens on this page. If we don't want to do this full redesign from a couple years ago, maybe we could revisit and look at the organizational part of it. #2476

@sstrubberg
Copy link
Member

sstrubberg commented Jun 27, 2024

Related: We need a way to designate the difference between component tokens on this page. If we don't want to do this #2476 from a couple years ago, maybe we could revisit and look at the organizational part of it. #2476

We could totally do this now that we have fluid inputs.

I'll drum up a new issue.

@alisonjoseph
Copy link
Member Author

this is done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants