Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tabs]: Refactor to provide TabList, TabPanels, TabPanel #10086

Closed
Tracked by #8487
tay1orjones opened this issue Nov 10, 2021 · 1 comment · Fixed by #10225
Closed
Tracked by #8487

[Tabs]: Refactor to provide TabList, TabPanels, TabPanel #10086

tay1orjones opened this issue Nov 10, 2021 · 1 comment · Fixed by #10225
Assignees
@tay1orjones @abbeyhrt
Labels
component: tabs
Milestone
v11 Beta 3

Comments

@tay1orjones
Copy link
Member

tay1orjones commented Nov 10, 2021 •
edited
Loading

The current implementation for tabs provides Tabs that contains one or more Tab. This issue is for refactoring the implementation to include separate components for the entire structure of Tabs to provide more flexibility and control.

Effectively the structure would be:

Tabs
  TabList
    Tab
  TabPanels
    TabPanel

This aligns with many other design systems approach to this component:

This will additionally impact the ability to more easily contain variants (line, contained, icon-only, etc) from #8487 without having to make new components.
@tay1orjones tay1orjones mentioned this issue Nov 10, 2021
Closed
6 tasks
@tay1orjones tay1orjones moved this to 🏗 In Progress in Design System Nov 10, 2021
@tay1orjones tay1orjones added this to the v11 Beta 3 milestone Nov 10, 2021
@abbeyhrt abbeyhrt mentioned this issue Nov 30, 2021
Merged
@abbeyhrt abbeyhrt mentioned this issue Dec 7, 2021
Merged
@kodiakhq kodiakhq bot closed this as completed in #10225 Dec 7, 2021
Repository owner moved this from 🏗 In Progress to ✅ Done in Design System Dec 7, 2021
@alexandertrefz
Copy link

FYI: The new TabPanels, TabPanel, and TabList components are not exposed through @carbon/react, however the refactored Tab Component is, effectively breaking the TabComponent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tay1orjones tay1orjones

@abbeyhrt abbeyhrt

Labels
component: tabs
Projects
Design System
Archived in project
Milestone
v11 Beta 3
Development

Successfully merging a pull request may close this issue.

feat(react): update Tabs API and delete next/Tab
3 participants
@alexandertrefz @tay1orjones @abbeyhrt