New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(StaticNotification): initial component functionality #15532
feat(StaticNotification): initial component functionality #15532
Conversation
✅ Deploy Preview for v11-carbon-react ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@tay1orjones Locally I can see the warning in the But if you check the deploy both variants looks the same. The Maybe when we deploy for real it might fix? 🤔 Let's keep an eye on it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
We just have to update the snapshot to fix the test error. For some reason I can't push a commit here
@guidari Yes this is actually intentional, the warning is guarded behind I'll see if I can get that snapshot updated to pass the ci check |
28cf192
Closes #15697
Based on conversations with @finken2 in #15319 and a few meetings later about blockers faced by their team, and consulting with IBMa - this introduces a new notification component with specific guidance outlined in storybook.
We'll test this with users before adding tests, marking stable, etc.
Changelog
New
unstable__StaticNotification
Testing / Reviewing