Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(StaticNotification): initial component functionality #15532

Merged

Conversation

tay1orjones
Copy link
Member

@tay1orjones tay1orjones commented Jan 12, 2024

Closes #15697

Based on conversations with @finken2 in #15319 and a few meetings later about blockers faced by their team, and consulting with IBMa - this introduces a new notification component with specific guidance outlined in storybook.

We'll test this with users before adding tests, marking stable, etc.

Changelog

New

  • Added experimental unstable__StaticNotification

Testing / Reviewing

  • Ensure the warning only pops when it should, and doesn't when it shouldn't

Copy link

netlify bot commented Jan 12, 2024

Deploy Preview for v11-carbon-react ready!

Name Link
🔨 Latest commit ebaf6e3
🔍 Latest deploy log https://app.netlify.com/sites/v11-carbon-react/deploys/65c148f544b93f00087765e4
😎 Deploy Preview https://deploy-preview-15532--v11-carbon-react.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@tay1orjones tay1orjones marked this pull request as ready for review January 25, 2024 20:43
@tay1orjones tay1orjones requested review from a team as code owners January 25, 2024 20:43
@guidari
Copy link
Contributor

guidari commented Jan 31, 2024

@tay1orjones Locally I can see the warning in the pop-the-warning variant:
Error: interactive child node(s) should have an aria-describedby property with a value matching the value of titleId.

But if you check the deploy both variants looks the same. The experimental-unstable-staticnotification--with-interactive-elements-that-pop-the-warning is not poping the warning like is happening locally.

Maybe when we deploy for real it might fix? 🤔 Let's keep an eye on it

Copy link
Contributor

@guidari guidari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀
We just have to update the snapshot to fix the test error. For some reason I can't push a commit here

@tay1orjones
Copy link
Member Author

@guidari Yes this is actually intentional, the warning is guarded behind __DEV__ which is only true in non-production environments. So the warning will never pop in production, but will be present in development environments where it can be appropriately addressed by devs.

I'll see if I can get that snapshot updated to pass the ci check

@tay1orjones tay1orjones added this pull request to the merge queue Feb 6, 2024
Merged via the queue into carbon-design-system:main with commit 28cf192 Feb 6, 2024
20 checks passed
@tay1orjones tay1orjones deleted the static-notification branch February 6, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Bug]: Click on Link button in ActionableNotification is moving the cursor focus to the Close button.
3 participants