Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA fixes: code snippet #1888

Closed
3 tasks done
shixiedesign opened this issue Feb 22, 2019 · 1 comment
Closed
3 tasks done

QA fixes: code snippet #1888

shixiedesign opened this issue Feb 22, 2019 · 1 comment
Assignees
Milestone

Comments

@shixiedesign
Copy link
Contributor

shixiedesign commented Feb 22, 2019

Overall:

  • Update all code snippet variants to use type token $code-01

Multiline:

  • Need background (same color as interface background) under "Show more" button and code snippet icon so that the code will be hidden when it runs under them; it's not like ghost button where it's just transparent and then you get the background on hover only. We need the same-color background shape to block out code.

problem:
image


spec: that background should be there always; it's just that when it's enabled, it is the same color as the code snippet background

image


  • If type overflows, fade out the copy with a G10 overlay (can we do this?):

image

@carbon-bot
Copy link
Contributor

🎉 This issue has been resolved in version 9.83.17 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants