Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate 16, 20 and 24 icons for redundancy #5597

Closed
90 tasks
chrisconnors-ibm opened this issue Mar 11, 2020 · 6 comments · Fixed by #7126
Closed
90 tasks

Evaluate 16, 20 and 24 icons for redundancy #5597

chrisconnors-ibm opened this issue Mar 11, 2020 · 6 comments · Fixed by #7126
Assignees
@chrisconnors-ibm
Labels
type: bug 🐛

Comments

@chrisconnors-ibm
Copy link
Contributor

chrisconnors-ibm commented Mar 11, 2020 •
edited by laurenmrice
Loading

Last batch of icons to evaluate for elimination!:
@joshblack
Copy link
Contributor

Hey there! Going to close this out due to inactivity, feel free to comment and I can re-open!

@chrisconnors-ibm
Copy link
Contributor Author

@conradennis could also evaluate these. otherwise I'll try to chip away at these!

@chrisconnors-ibm chrisconnors-ibm self-assigned this Jun 23, 2020
@laurenmrice
Copy link
Member

Reopening to finish this.

@laurenmrice laurenmrice reopened this Sep 17, 2020
This was referenced Sep 18, 2020
Closed
Closed
This was referenced Sep 25, 2020
Closed
Merged
@conradennis
Copy link
Contributor

conradennis commented Oct 19, 2020 •
edited
Loading

duplicate icons with different names in the library:

  • awake, light, sun
  • misuse--alt, misuse--outline, close--outline
  • close--filled, misuse

updated icons to reduce need for redundancy:

  • arrow--down
  • arrow--left
  • arrow--right
  • arrow--up
  • download
  • error--outline
  • error--filled
  • export
  • information
  • information--filled
  • information--square--filled
  • launch
  • new-tab
  • notification
  • notification--off
  • play
  • redo
  • restart
  • search
  • undo
  • upload
  • user--avatar
  • warning--alt
  • warning--alt--filled
  • zoom--in
  • zoom--out

there are also a few icons that can be reworked to render better at smaller sizes but when proper tweaks are made they just look worse/unbalanced compared to their original versions. I'll need to work with these a bit more:

  • maximize
  • minimize
  • play--filled
  • play--outline
  • play--outline--filled

any icons I update will be included in my next batch PR later this week so once I make that issue I'll reference it here and then when it's merged we should be able to close this one.

@laurenmrice
Copy link
Member

Thank you, Conrad! 🙌🏻

conradennis added a commit to conradennis/carbon that referenced this issue Oct 23, 2020
@conradennis
feat(UI icons): new icons september october
c0543dc 
Submitting new and updated UI icons from September and October
all updates and additions approved by BXD

193 net new icons
48 updated icons
updated categories.yml with additions
updated ui-icon-master.ai with additions and updates

Closes: carbon-design-system#5597
conradennis added a commit to conradennis/carbon that referenced this issue Oct 23, 2020
@conradennis
feat(UI icons): new icons september and october
12f19ed 
Submitting new and updated UI icons from September and October
all updates and additions approved by BXD

193 net new icons
48 updated icons
updated categories.yml with additions
updated ui-icon-master.ai with additions and updates

Closes: carbon-design-system#5597
@conradennis conradennis mentioned this issue Oct 23, 2020
Merged
@conradennis
Copy link
Contributor

PR including all updated icons mentioned above: #7126

we should be able to remove all of the icons Connors listed and close the issue

@kodiakhq kodiakhq bot closed this as completed in #7126 Nov 2, 2020
kodiakhq bot added a commit that referenced this issue Nov 2, 2020
@conradennis @laurenmrice
@dakahn @joshblack @kodiakhq
feat(UI icons): new icons september and october (#7126)
14e8871 
* feat(UI icons): new icons september and october

Submitting new and updated UI icons from September and October
all updates and additions approved by BXD

193 net new icons
48 updated icons
updated categories.yml with additions
updated ui-icon-master.ai with additions and updates

Closes: #5597

* fix(icons): update metadata

* chore(icons): update category metadata

* test(e2e): update public api snapshots

* test(react): update snapshots

* test(icons-vue): update e2e snapshots for vue

Co-authored-by: Lauren Rice <43969356+laurenmrice@users.noreply.github.com>
Co-authored-by: D.A. Kahn <dakahn@protonmail.com>
Co-authored-by: DAK <40970507+dakahn@users.noreply.github.com>
Co-authored-by: Josh Black <josh@josh.black>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
kodiakhq bot added a commit that referenced this issue Aug 17, 2021
@conradennis @joshblack @kodiakhq
feat(icons): add new icons for July, August 2021 (#9473)
ebf0dc6 
* feat(UI icons): new icons september october

Submitting new and updated UI icons from September and October
all updates and additions approved by BXD

193 net new icons
48 updated icons
updated categories.yml with additions
updated ui-icon-master.ai with additions and updates

Closes: #5597

* feat(UI icons): new icons july august 2021

Submitting new and updated UI icons from July and August 2021
all updates and additions approved by BXD

89 net new icons
3 updated icons
updated categories.yml with additions
updated ui-icon-master.ai with additions and updates

* chore(icons): update metadata and snapshots

Co-authored-by: Josh Black <josh@josh.black>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisconnors-ibm chrisconnors-ibm

Labels
type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(UI icons): new icons september and october conradennis/carbon
4 participants
@joshblack @conradennis @chrisconnors-ibm @laurenmrice