-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(code-snippet): update component to spec #7214
fix(code-snippet): update component to spec #7214
Conversation
Deploy preview for carbon-elements ready! Built with commit d779453 |
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit d779453 https://deploy-preview-7214--carbon-components-react.netlify.app |
c769b65
to
c49b1f9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
The light prop needs to also have an active state change for the copying functionality for inline/single line/multi-line code snippets. It is not showing up.
-
I think the multi-line code snippet copy button is too large which is why it is misaligning with the ghost button below it. It needs to be a 32px icon button instead of 40px.
c49b1f9
to
d5aeec7
Compare
e5cb2f2
to
973718f
Compare
new active token and hover token updates will be here #7275 |
973718f
to
48815a6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
48815a6
to
a4ce4e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thank you 🙌🏻
Part of #7159
This PR adds an active style to the code snippet copy buttons and repositions the button to be aligned with the "show more" chevron in multiline snippets.
Changelog
New
Changed
Testing / Reviewing
Confirm the code snippet matches the spec