-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react-components): update prop-type for invalidText, warnText #7433
fix(react-components): update prop-type for invalidText, warnText #7433
Conversation
✔️ Deploy preview for carbon-elements ready! 🔨 Explore the source changes: afacd61 🔍 Inspect the deploy logs: https://app.netlify.com/sites/carbon-elements/deploys/5fd3b669417772000785417e 😎 Browse the preview: https://deploy-preview-7433--carbon-elements.netlify.app |
Deploy preview for carbon-components-react ready! Built without sensitive environment variables with commit afacd61 https://deploy-preview-7433--carbon-components-react.netlify.app |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me, seems like this is the only way to avoid prop type warnings with react-intl
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me, thanks for taking the time to contribute! 👍 ✅
This PR makes to change prop-type for
invalidText, warnText
ofTextArea
,ComboBox
,DatePickerInput
,Dropdown
,ListBox
,FilterableMultiSelect
,MultiSelect
,NumberInput
,Select
,TimePicker
to support internationalization.The problem at example
Changelog
Changed
string
tonode
forinvalidText, warnText
ofTextArea
,ComboBox
,DatePickerInput
,Dropdown
,ListBox
,FilterableMultiSelect
,MultiSelect
,NumberInput
,Select
,TimePicker
Testing / Reviewing
TextArea
,ComboBox
,DatePickerInput
,Dropdown
,ListBox
,FilterableMultiSelect
,MultiSelect
,NumberInput
,Select
,TimePicker