Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Search): customize icon #8537

Merged
merged 7 commits into from
May 5, 2021
Merged

feat(Search): customize icon #8537

merged 7 commits into from
May 5, 2021

Conversation

fabpico
Copy link
Contributor

@fabpico fabpico commented Apr 29, 2021

Closes #8480

@fabpico fabpico requested a review from a team as a code owner April 29, 2021 10:26
@netlify
Copy link

netlify bot commented Apr 29, 2021 •
edited
Loading

Deploy preview for carbon-elements ready!

Built with commit ada0e93

https://deploy-preview-8537--carbon-elements.netlify.app

@netlify
Copy link

netlify bot commented Apr 29, 2021 •
edited
Loading

Deploy preview for carbon-components-react ready!

Built without sensitive environment variables with commit ada0e93

https://deploy-preview-8537--carbon-components-react.netlify.app

tay1orjones
tay1orjones approved these changes May 4, 2021
View reviewed changes
Copy link
Member

@tay1orjones tay1orjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @FabianPiconeDev - I added a commit here to include the PropTypes definition as well as rename the prop to renderIcon to be more consistent with other components that accept an icon as a prop.

@tay1orjones tay1orjones requested a review from tw15egan May 4, 2021 20:34
@fabpico fabpico requested a review from a team as a code owner May 5, 2021 22:02
@kodiakhq kodiakhq bot merged commit 3158c5d into carbon-design-system:main May 5, 2021
@fabpico
Copy link
Contributor Author

fabpico commented May 7, 2021

@tw15egan Sorry I was a bit busy, I was just about to do it, then I saw that @tay1orjones did it. Thanks! :-)

@tw15egan tw15egan mentioned this pull request May 10, 2021
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tay1orjones tay1orjones tay1orjones approved these changes

@tw15egan tw15egan tw15egan approved these changes

@dakahn dakahn dakahn approved these changes

Assignees
No one assigned
Labels
status: ready to merge 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom icon for search component
4 participants
@fabpico @tay1orjones @tw15egan @dakahn