Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

for uses in instead of :, and implement #542. #563

Merged
merged 2 commits into from
Jun 3, 2021
Merged

for uses in instead of :, and implement #542. #563

merged 2 commits into from
Jun 3, 2021

Conversation

josh11b
Copy link
Contributor

@josh11b josh11b commented Jun 3, 2021

No description provided.

@josh11b josh11b requested review from a team as code owners June 3, 2021 05:18
@google-cla google-cla bot added the cla: yes PR meets CLA requirements according to bot. label Jun 3, 2021
chandlerc
chandlerc approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@chandlerc chandlerc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

While we should fully reconsider the exact loop variable syntax at some point, but I think an interim of replacing : with in is a strict improvement to avoid active confusion.

@josh11b josh11b merged commit 8b57b9f into carbon-language:trunk Jun 3, 2021
@josh11b josh11b deleted the for-in branch June 3, 2021 14:56
@jonmeow jonmeow mentioned this pull request Jul 2, 2021
Merged
jonmeow added a commit that referenced this pull request Jul 9, 2021
@jonmeow @zygoloid @josh11b
var ordering (#618)
db9da84 
Propose the decision from #542, noting implementation from #563

Also integrates some of #339 into `variables.md` because that's actually how this started, looking for a proposal reference for #542 

Co-authored-by: Richard Smith <richard@metafoo.co.uk>
Co-authored-by: josh11b <josh11b@users.noreply.github.com>
chandlerc pushed a commit that referenced this pull request Jun 28, 2022
@josh11b
for uses in instead of :, and implement #542. (#563)
c836ae7 
* `for` uses `in` instead of `:`, and implement #542.
chandlerc pushed a commit that referenced this pull request Jun 28, 2022
@jonmeow @zygoloid @josh11b
var ordering (#618)
199c7e3 
Propose the decision from #542, noting implementation from #563

Also integrates some of #339 into `variables.md` because that's actually how this started, looking for a proposal reference for #542 

Co-authored-by: Richard Smith <richard@metafoo.co.uk>
Co-authored-by: josh11b <josh11b@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandlerc chandlerc chandlerc approved these changes

Assignees
No one assigned
Labels
cla: yes PR meets CLA requirements according to bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josh11b @chandlerc