Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to cardano-db-sync extended for improved Epoch performance #123

Merged
merged 3 commits into from
Mar 20, 2020

Conversation

rhyslbw
Copy link
Contributor

@rhyslbw rhyslbw commented Mar 20, 2020

Fixes #52

This PR incorporates the new Cardano Docker images to provide greater control over deployment, documentation, local development, and improves maintainability with an improved snapshot script.

It also is now tested against cardano-db-sync-extended, which writes the epoch data to a table, rather than calculating it at query time, which was a poor performer.

@rhyslbw rhyslbw added the enhancement New feature or request label Mar 20, 2020
@rhyslbw rhyslbw self-assigned this Mar 20, 2020
@rhyslbw rhyslbw merged commit 2dd9e17 into master Mar 20, 2020
@rhyslbw rhyslbw deleted the chore/cardano-db-sync-extended branch March 20, 2020 05:51
rvl pushed a commit that referenced this pull request Dec 14, 2020
123: Update index-state r=newhoggy a=newhoggy

* Update index-state
* Add lower-bounds to nonempty-containers
* Do not define ToJSON/FromJSON instances of `NESet`

The instance fix addresses this error when building with new index-state:

```
src/Cardano/Prelude/Orphans.hs:27:10: error:
    Duplicate instance declarations:
      instance (Ord a, FromJSON a) => FromJSON (NESet a)
        -- Defined at src/Cardano/Prelude/Orphans.hs:27:10
      instance (FromJSON a, Ord a) => FromJSON (NESet a)
        -- Defined in ‘Data.Set.NonEmpty.Internal’
   |
27 | instance (Ord a, FromJSON a) => FromJSON (NESet a) where
   |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

src/Cardano/Prelude/Orphans.hs:30:10: error:
    Duplicate instance declarations:
      instance (Ord a, ToJSON a) => ToJSON (NESet a)
        -- Defined at src/Cardano/Prelude/Orphans.hs:30:10
      instance ToJSON a => ToJSON (NESet a)
        -- Defined in ‘Data.Set.NonEmpty.Internal’
   |
30 | instance (Ord a, ToJSON a) => ToJSON (NESet a) where
   |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
```

Co-authored-by: John Ky <john.ky@iohk.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Known limitation relating to Epoch querying
1 participant