Add response code verification into integration DSL #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piotr-iohk
force-pushed
the
piotr/56/qa-review-and-experiment
branch
from
10acfef
to
f290b69
Compare
Anviking
reviewed
Mar 21, 2019
KtorZ
approved these changes
Mar 22, 2019
piotr-iohk
force-pushed
the
piotr/56/qa-review-and-experiment
branch
from
1c503d5
to
a92d273
Compare
|
Fixed and cleaned up the imports. 👍 |
|
Will rebase/squash and merge after #107 👍 |
KtorZ
force-pushed
the
piotr/56/qa-review-and-experiment
branch
from
d8217f9
to
8e5b71a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
#104
Overview
expectResponseCodemethod into DSL and some temporary test on external servicehttp://httpbin.orgjust to check it works. The method checks if the response has expected response code.Comments
This
expectResponseCodeonly works for response produced byresponse'method which just returns raw response in the form ofResponse ByteString. I kinda like it bacuase it seems you can get a response code or response body or response headers from it using different methods fromNetwork.HTTP.Client. At this point it seems to be more versatile thanresponse(oldunsafeRequest) which contains additional logic for getting the response depending on response codes.¯_(ツ)_/¯