Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ApiEpochInfo type. #1095

Merged
merged 2 commits into from
Nov 29, 2019
Merged

Add ApiEpochInfo type. #1095

merged 2 commits into from
Nov 29, 2019

Conversation

jonathanknowles
Copy link
Member

Issue Number

#1087

Overview

  • Added an ApiEpochInfo type.
  • Added roundtrip JSON encoding support.
  • Added roundtrip JSON encoding tests.
  • Added "pointless" tests to produce code coverage for record accessors.

Comments

Copy link
Contributor

@paweljakubas paweljakubas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jonathanknowles
Copy link
Member Author

bors r+

iohk-bors bot added a commit that referenced this pull request Nov 29, 2019
1095: Add `ApiEpochInfo` type. r=jonathanknowles a=jonathanknowles

# Issue Number

#1087 

# Overview

<!-- Detail in a few bullet points the work accomplished in this PR -->

- [x] Added an `ApiEpochInfo` type.
- [x] Added roundtrip JSON encoding support.
- [x] Added roundtrip JSON encoding tests.
- [x] Added "pointless" tests to produce code coverage for record accessors.

# Comments

<!-- Additional comments or screenshots to attach if any -->

<!-- 
Don't forget to:

 ✓ Self-review your changes to make sure nothing unexpected slipped through
 ✓ Assign yourself to the PR
 ✓ Assign one or several reviewer(s)
 ✓ Once created, link this PR to its corresponding ticket
 ✓ Assign the PR to a corresponding milestone
 ✓ Acknowledge any changes required to the Wiki
-->


Co-authored-by: Jonathan Knowles <jonathan.knowles@iohk.io>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 29, 2019

Build succeeded

@iohk-bors iohk-bors bot merged commit 270dcad into master Nov 29, 2019
@KtorZ KtorZ deleted the jonathanknowles/api-epoch-info branch November 29, 2019 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants