API smart constructors #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use this function to simplify the `FromJSON` instance for `ApiMnemonic`.
* Use these functions to simplify the `FromJSON` and `ToJSON` instances for `ApiT Address`. * Export these functions, allowing them to be used elsewhere.
* Use these functions to simplify the `ApiT (Passphrase "encryption")` FromJSON and ToJSON instances. * Export them from the module.
10 tasks
KtorZ
approved these changes
Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Issue #96
Overview
This PR defines decoders (smart constructors) and encoders for the following types defined within
Cardano.Wallet.Api.Types:ApiT AddressApiT (Passphrase "encryption")ApiMnemonicT sizes purposeApiT WalletNameWe export the decoders so that they may eventually be used by the CLI when constructing values with which to call the API.
We also modify the relevant
FromJSONandToJSONinstances to reuse the extracted-out decoders and encoders.