Tests for tracking known transactions #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
KtorZ
reviewed
Apr 4, 2019
| prop_applyBlockTxHistoryIncoming :: WalletState -> Property | ||
| prop_applyBlockTxHistoryIncoming s = conjoin (map prop wallets) | ||
| where | ||
| wallets = scanl (flip applyBlock) (initWallet s) blockchain |
There was a problem hiding this comment.
Is there a particular reason to check all intermediate state and not only the last one 🤔 ?
| inTxs = filter isIncoming $ Set.toList $ getTxHistory wallet | ||
| isIncoming (_, m) = direction m == Incoming | ||
| txOuts = map (Set.fromList . map address . outputs . fst) inTxs | ||
| overlaps a b = not (Set.disjoint a b) |
There was a problem hiding this comment.
It'll be nice to add a coverage checks that makes sure that addrs and ourAddresses aren't just empty all the time.
| it "Incoming transactions have output addresses that belong to the wallet" | ||
| (property prop_applyBlockTxHistoryIncoming) | ||
| it "Any transction involving our addresses must be incoming" | ||
| (property prop_applyBlockTxHistoryOurs) |
There was a problem hiding this comment.
I don't get this second property 🤔 ? What about outgoing transactions with change?
4 tasks
…model tests This allows for having the original transactions that are referred to in some other blocks, and therefore, counts for outgoing transactions as well during testing
… to keep the tx history stored in the wallet state
KtorZ
force-pushed
the
rvl/90/transaction-properties
branch
from
29cd470
to
6aca526
Compare
KtorZ
approved these changes
Apr 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to issue #90
Overview
This is a start for tests of the transaction tracking part of
applyBlock.