Unit test for LocalStateQuery #1618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rvl
force-pushed
the
rvl/adp-83/local-state-query-test
branch
2 times, most recently
from
6a54497
to
2418f9d
Compare
KtorZ
reviewed
May 4, 2020
| recoverAll retryPolicy $ const $ | ||
| getTxParameters nl `shouldReturn` txParameters gbp | ||
| msg <- mapMaybe isMsgTxParams <$> getLogs | ||
| msg `shouldBe` [txParameters gbp] |
There was a problem hiding this comment.
Feels more like an integration test than a unit test though.
There was a problem hiding this comment.
The byron network layer is not set up very well for unit testing, so using the real cardano-node was the best that I could do.
KtorZ
approved these changes
May 4, 2020
|
bors r+ |
Build failed |
rvl
force-pushed
the
rvl/adp-83/local-state-query-test
branch
from
2418f9d
to
87e8dc3
Compare
|
Socket file issue on macos - fixed. bors r+ |
Build succeeded |
KtorZ
added
the
ADDING FEATURE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Relates to #1577 / ADP-83.
Overview
Adds a test of NetworkLayer.getTxParameters against the self-node